Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355817 - 'Add' should not appear in context menu on already shared resources
Summary: 'Add' should not appear in context menu on already shared resources
Status: VERIFIED WONTFIX
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 07:05 EDT by Dani Megert CLA
Modified: 2012-03-13 05:04 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-25 07:05:01 EDT 
org.eclipse.egit.ui_1.1.0.201108230343.jar

'Add' should not appear in context menu of already shared resources.
Comment 1 Matthias Sohn CLA 2011-08-25 08:11:00 EDT 
"Add" is not only about sharing new files but also about staging changes incrementally to the git index which is preparing the next commit (the git staging view displays status of this), so you can do some few modifications, stage them using "Add", then do more modifications and run "Add" again.
Comment 2 Dani Megert CLA 2011-08-25 08:19:17 EDT 
(In reply to comment #1)
> "Add" is not only about sharing new files but also about staging changes
> incrementally to the git index which is preparing the next commit (the git
> staging view displays status of this), so you can do some few modifications,
> stage them using "Add", then do more modifications and run "Add" again.

Wouldn't that better be named 'Add to Git Index'?
Comment 3 Kevin Sawicki CLA 2012-03-05 20:43:49 EST 
This menu item been renamed to 'Add to Index' making it hopefully more clear what the beavior is.

I am going to close this as WONTFIX since that menu option is still needed for staging purposes.
Comment 4 Dani Megert CLA 2012-03-13 05:04:36 EDT 
(In reply to comment #3)
> This menu item been renamed to 'Add to Index' making it hopefully more clear
> what the beavior is.
> 
> I am going to close this as WONTFIX since that menu option is still needed for
> staging purposes.

Agreed.