Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355729 - Incremental build produces an additional missing EE description marker for each build
Summary: Incremental build produces an additional missing EE description marker for ea...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M2   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 11:48 EDT by Michael Rennie CLA
Modified: 2011-09-14 16:26 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2011-08-24 11:48:17 EDT 
Version: 3.8.0
Build id: I20110823-0925

Steps
1. new workspace
2. remove all EE descriptions you have installed
3. check out org.eclipse.ui.navigator
4. wait for a build you get an error marker for no ee descriptions (OK)
5. edit any file in ui.navigator and save - you get another error marker for no ee descriptions (BAD)
Comment 1 Olivier Thomann CLA 2011-08-24 11:52:51 EDT 
I guess we simply don't clean up the existing marker.
I'll take a look.
Comment 2 Michael Rennie CLA 2011-08-24 12:01:34 EDT 
(In reply to comment #1)
> I guess we simply don't clean up the existing marker.
> I'll take a look.

I have a fix, but git won't seem to let me push it to master *or* create a patch for it.

The fix is to add the following snippet to our cleanupUsageMarkers(..) method:

if(resource.getType() != IResource.PROJECT) {
  IProject pj = resource.getProject();
  if(pj != null) {
    pj.deleteMarkers(IApiMarkerConstants.API_USAGE_PROBLEM_MARKER, false, IResource.DEPTH_ZERO);
  }
}
Comment 3 Remy Suen CLA 2011-08-24 12:04:27 EDT 
(In reply to comment #2)
> I have a fix, but git won't seem to let me push it to master *or* create a
> patch for it.

Did you commit your changes? You can't make a patch unless you've committed your changes to your branch.
Comment 4 Michael Rennie CLA 2011-08-24 12:17:37 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > I have a fix, but git won't seem to let me push it to master *or* create a
> > patch for it.
> 
> Did you commit your changes? You can't make a patch unless you've committed
> your changes to your branch.

Yup, I committed to my local repo and am met with an NPE each time I use the patch wizard for git. I tried sync'ing and another pull + merge but it still will not allow me to push to master.

Created bug 355732 for the NPEs.
Comment 5 Olivier Thomann CLA 2011-08-24 12:23:58 EDT 
Use the git command line tool to commit and push your change.
Comment 6 Michael Rennie CLA 2011-08-29 10:58:22 EDT 
It appears that my fix made it into master somehow...marking this fixed now.
Comment 7 Curtis Windatt CLA 2011-09-14 16:26:08 EDT 
Verified in I20110913-2000