Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355691 - Synchronize view shows unexpected changes which I can't get rid of
Summary: Synchronize view shows unexpected changes which I can't get rid of
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 07:53 EDT by Dani Megert CLA
Modified: 2011-09-20 10:37 EDT (History)
6 users (show)

See Also:


Attachments
Picture of my workbench (82.40 KB, image/png)
2011-08-24 07:57 EDT, Dani Megert CLA
no flags Details
Picture of my workbench (93.79 KB, image/png)
2011-08-24 08:00 EDT, Dani Megert CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-24 07:53:49 EDT
org.eclipse.egit.ui_1.1.0.201108230343.jar

Maybe I did something wrong in the setup but it's weird:

- I have my project imported from master [good]
- I compare my project with local master: no change [good]
- I compare my project with remote master: no change [good]
- but Team > Synchronize gives me hundred changes in the Synchronize view
  - Merge says: no changes to merge
  - pull does not help
  - push says: it's up to date


I'm new to EGit, so I might have done something wrong or understood something wrong (or maybe the repo which was migrated from CVS is broken) but the fact that compare and the Synchronize view show such a different state looks like a severe bug and at this point I have no clue how to bring the Synchronize view into a usable state.

Repo: ssh://userid@git.eclipse.org/gitroot/platform/eclipse.platform.text.git
Comment 1 Dani Megert CLA 2011-08-24 07:57:33 EDT
Created attachment 202079 [details]
Picture of my workbench
Comment 2 Dani Megert CLA 2011-08-24 08:00:27 EDT
Created attachment 202080 [details]
Picture of my workbench
Comment 3 Benjamin Muskalla CLA 2011-08-24 08:02:08 EDT
Dani, it would be interesting to see your sync view in the Git Change Set Mode to see where these changes come from.
Comment 4 Dani Megert CLA 2011-08-24 08:04:28 EDT
(In reply to comment #3)
> Dani, it would be interesting to see your sync view in the Git Change Set Mode
> to see where these changes come from.

Sure. How do I do this?
Comment 5 Matthias Sohn CLA 2011-08-24 08:21:37 EDT
I suspect your are using autocrlf settings which aren't yet supported (see bug 301775)
Comment 6 Dani Megert CLA 2011-08-24 08:24:22 EDT
(In reply to comment #5)
> I suspect your are using autocrlf settings which aren't yet supported (see bug
> 301775)
I didn't change any preference.

>Dani, it would be interesting to see your sync view in the Git Change Set Mode
>to see where these changes come from.
Mmh: in that mode the view says that there are no change (sigh!), but that the Java Workspace has incoming/outgoing changes.
Comment 7 Dani Megert CLA 2011-08-24 08:26:23 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > I suspect your are using autocrlf settings which aren't yet supported (see bug
> > 301775)
> I didn't change any preference.

I just verified that this is set to 'false'.
Comment 8 Dani Megert CLA 2011-08-24 08:28:13 EDT
1. delete the project
2. hard reset local master
3. import the project again
==> same problem.
Comment 9 Dani Megert CLA 2011-08-24 09:38:58 EDT
I gave up (but kept the old workspace) and restarted with a new workspace. This time the result was better at the beginning: The Synchronize view is empty this time. BUT
1. after a change I get an outgoing change with a '>' [good]
2. commit ==> the file stays in the view but the '>' goes away [good???]
3. I push the change and get a dialog that confirms it worked [good]
4. BUT: the changed file still stays in the Synchronize view [bad]
   ==> no way to get rid of that file and again, the change set view says there's
   no change, except for the Java Workspace.
Comment 10 Dani Megert CLA 2011-08-24 10:09:58 EDT
I gave up on the latest and greatest (201108230343) and switched to org.eclipse.egit.ui_1.0.0.201106090707-r which seems to work better. The scenario from comment 9 works like a charm.

So, while I found a way around the problem it still remains a BLOCKER regarding 201108230343.
Comment 11 Dariusz Luksza CLA 2011-08-25 16:55:09 EDT
(In reply to comment #9)
> 4. BUT: the changed file still stays in the Synchronize view [bad]
>    ==> no way to get rid of that file and again, the change set view says
> there's
>    no change, except for the Java Workspace.

It seams that after commit '521e41c [sync] Simplify implementation of git remote objects' the workspace model wasn't properly refreshed after repository change event. I've already pushed fix for this issue[1].

[1] http://egit.eclipse.org/r/4069
Comment 12 Dani Megert CLA 2011-08-26 02:35:59 EDT
(In reply to comment #11)
> (In reply to comment #9)
> > 4. BUT: the changed file still stays in the Synchronize view [bad]
> >    ==> no way to get rid of that file and again, the change set view says
> > there's
> >    no change, except for the Java Workspace.
> 
> It seams that after commit '521e41c [sync] Simplify implementation of git
> remote objects' the workspace model wasn't properly refreshed after repository
> change event. I've already pushed fix for this issue[1].
> 
> [1] http://egit.eclipse.org/r/4069

Should this be in the latest N-build? I just tried again using Eclipse EGit	1.1.0.201108251914 from http://download.eclipse.org/egit/updates-nightly and the problem is still there.
Comment 13 Dani Megert CLA 2011-08-26 02:55:20 EDT
Closing and redoing the synchronization does not fix the problem, but after a restart it works (until I commit again).
Comment 14 Dariusz Luksza CLA 2011-08-26 03:31:52 EDT
(In reply to comment #12)
> Should this be in the latest N-build? I just tried again using Eclipse EGit   
> 1.1.0.201108251914 from http://download.eclipse.org/egit/updates-nightly and
> the problem is still there.

No this change isn't merged into master. It just awaiting for a review, it needs to be accepted by another EGit commiter to be available in nightly build
Comment 16 Dani Megert CLA 2011-08-30 06:14:19 EDT
Verified in 1.1.0.201108281957.
Comment 17 Mauro Molinari CLA 2011-09-20 10:37:36 EDT
Sorry for this intrusion. I found a similar problem for Subversive using Eclipse 3.7: after committing a file, it still looks like modified in the Synchronize View. It is also marked as ">" in the Package/Project Explorer. Anyway, changes have been committed, as I can see in the SVN Repository Explorer. Doing a Team => Cleanup does not help. Closing and reopening the project does not help. If I look at the file revisions, they are the latest ones. I have to close and restart Eclipse to see the files as not modified correctly!
This has started to happen with Eclipse 3.7. I have similar problems (synchronize view not refreshing after commit) using CVS too. I never had such problems with 3.6.
My question is: maybe there was a change in the Team API that caused this? Could be the problems I see with Subversive and CVS related to this EGit problem? Any help would be appreciated, because I can't provide steps to reproduce this consistently and the problem is severe...