Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355688 - Git Repositories view title not italic when doing work
Summary: Git Repositories view title not italic when doing work
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 06:57 EDT by Dani Megert CLA
Modified: 2011-09-16 03:08 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-24 06:57:00 EDT 
org.eclipse.egit.ui_1.1.0.201108230343.jar

Git Repositories view title not italic while doing work. This looks like the view does not use the right APIs when starting the job.
Comment 1 Kevin Sawicki CLA 2011-09-01 20:16:32 EDT 
The refresh job in this view is using IWorkbenchSiteProgressService to schedule the job.

The view title text does appear to be italic when setting a breakpoint in the Job's run method.
Comment 2 Dani Megert CLA 2011-09-02 02:53:52 EDT 
Interesting. But you also see the problem, right?
Comment 3 Dani Megert CLA 2011-09-02 03:49:56 EDT 
Just tried again using '1.1.0.201108281957'.
The task I executed was cloning a Git repository by pressing the button in the view's toolbar.
Comment 4 Kevin Sawicki CLA 2011-09-02 14:29:13 EDT 
Ah, apologies, I was only checking the refresh job updated the text which is does.

I agree the view should show progress as well for other job families that are invoked from the view.

Thanks for the clarification.
Comment 5 Kevin Sawicki CLA 2011-09-02 14:48:44 EDT 
Proposed fix pushed to: http://egit.eclipse.org/r/#change,4128

Marks the Git Repositories view as busy when a clone job is running.
Comment 6 Matthias Sohn CLA 2011-09-03 19:33:20 EDT 
merged as dbb4a404e43ce114eb78e212d2da4cdf477868fa
Comment 7 Dani Megert CLA 2011-09-16 03:08:36 EDT 
Verified in 1.1.0.201109111618.