Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355637 - Context menu in 'Git Tree Compare' seems not to work
Summary: Context menu in 'Git Tree Compare' seems not to work
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 2.1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 376242 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-08-24 06:02 EDT by Dani Megert CLA
Modified: 2012-09-04 06:33 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-24 06:02:44 EDT 
org.eclipse.egit.ui_1.1.0.201108230343.jar

The context menu in 'Git Tree Compare' seems not to work.
Comment 1 Remy Suen CLA 2011-08-25 17:19:28 EDT 
Looking at the code, I think there just isn't a context menu and not necessarily a programmatic error.
Comment 2 Dani Megert CLA 2011-08-26 02:08:21 EDT 
(In reply to comment #1)
> Looking at the code, I think there just isn't a context menu and not
> necessarily a programmatic error.

Still an error though ;-)
Comment 3 Remy Suen CLA 2011-08-26 07:01:06 EDT 
(In reply to comment #2)
> Still an error though ;-)

What kind of entries did you expect to see, Dani? Well, besides 'Open'.
Comment 4 Dani Megert CLA 2011-08-26 07:08:25 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Still an error though ;-)
> 
> What kind of entries did you expect to see, Dani? Well, besides 'Open'.

E.g. those that I also see in the Synchronize view.
Comment 5 Markus Keller CLA 2011-09-27 15:45:21 EDT 
Open, Open With, Show In, Copy.

I guess the rest are CVS-specific actions that are not really applicable for Git, since Git has no operations to update individual files.
Comment 6 Dani Megert CLA 2012-08-28 11:24:29 EDT 
*** Bug 376242 has been marked as a duplicate of this bug. ***
Comment 7 Dani Megert CLA 2012-08-29 11:28:28 EDT 
I need that menu. I'll fix it.
Comment 8 Dani Megert CLA 2012-08-31 05:27:31 EDT 
https://git.eclipse.org/r/#/c/7534/ pushed to Gerrit for review.

This fix adds the menus for the object contributions, 'Show In' and 'Open Working Tree Version'. As an additional goodie it adds the missing selection provider, so that other views (e.g. History view) can track the selection of the Tree Compare view.
Comment 10 Robin Stocker CLA 2012-09-03 07:25:22 EDT 
Added to New and Noteworthy for 2.1:

http://wiki.eclipse.org/EGit/New_and_Noteworthy/2.1#Context_menu_in_Git_Tree_Compare_view
Comment 11 Dani Megert CLA 2012-09-04 02:25:26 EDT 
(In reply to comment #10)
> Added to New and Noteworthy for 2.1:
> 
> http://wiki.eclipse.org/EGit/New_and_Noteworthy/2.
> 1#Context_menu_in_Git_Tree_Compare_view

Thanks!
Comment 12 Dani Megert CLA 2012-09-04 02:26:24 EDT 
Verified in 2.1.0.201209032123.
Comment 13 Dani Megert CLA 2012-09-04 03:04:05 EDT 
Small improvement (don't show context menu if selection is empty):
https://git.eclipse.org/r/#/c/7577/
Comment 14 Robin Stocker CLA 2012-09-04 06:33:45 EDT 
(In reply to comment #13)
> Small improvement (don't show context menu if selection is empty):
> https://git.eclipse.org/r/#/c/7577/

Also merged:

https://git.eclipse.org/c/egit/egit.git/commit/?id=bd37aa463fe373d01078519abbc9a271ec6b3d3c