Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355631 - Add shortcut for adding/removing loop characteristics
Summary: Add shortcut for adding/removing loop characteristics
Status: RESOLVED FIXED
Alias: None
Product: BPMN2Modeler
Classification: SOA
Component: UI (show other bugs)
Version: 0.0.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.0.1-M1   Edit
Assignee: Robert Brodt CLA
QA Contact:
URL: https://issues.jboss.org/browse/JBPM-...
Whiteboard:
Keywords:
Depends on:
Blocks: 355648
  Show dependency tree
 
Reported: 2011-08-24 05:52 EDT by Robert Brodt CLA
Modified: 2012-10-09 11:42 EDT (History)
0 users

See Also:
bbrodt: iplog+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Brodt CLA 2011-08-24 05:52:38 EDT
https://issues.jboss.org/browse/JBPM-3091
Comment 1 Robert Brodt CLA 2011-08-24 06:51:32 EDT
Currently need to select the relevant node, then go to the properties tab (advanced) and then create the top level property for the loop characteristic.

We probably need to decide what actions a user will do most frequently and provide short cuts on the context menu. Other more detailed activities could probably remain in the advanced properties panel.
Comment 2 Brian Fitzpatrick CLA 2011-12-09 13:53:53 EST
After looking into this a bit, it's like the MessageFlow where you can define an expression. In this case however, you add a StandardLoopCharacteristics object to the Activity, and that in turn has an Expression and a "testBefore" boolean flag. 

So we should be able to do this something similar to how we do the Expression for a MessageFlow where it has a button to add a StandardLoopCharacteristics object to the model and show a composite where the user can add an expression and set the loop flag.
Comment 3 Brian Fitzpatrick CLA 2011-12-13 18:21:50 EST
Have added the first part of this to the code and pushed it in. The difficulty comes with rendering lower-level attributes and references. 

For example, we need to handle expressions for StandardLoopCharacteristics' two attributes - LoopCondition and LoopMaximum. 

And for MultiInstanceLoopCharacteristics, there are many more bits in there to deal with. 

When I tried referencing registered property composites I ended up with a bunch of gobbledy-gook. So I'm still working on this, but the first part (i.e. being able to add LoopCharacteristics to a Called Activity is there.
Comment 4 Robert Brodt CLA 2012-03-01 09:09:51 EST
The latest iteration of the code adds radio buttons (None, Standard and Multi Instance) to the Sub Process property tab. I think is good enough for now.