Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355613 - Default target is selected when invalid targets are passed
Summary: Default target is selected when invalid targets are passed
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Satyam Kandula CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 04:23 EDT by Satyam Kandula CLA
Modified: 2011-08-30 11:20 EDT (History)
2 users (show)

See Also:
daniel_megert: pmc_approved+
Michael_Rennie: review+


Attachments
Patch (7.13 KB, text/plain)
2011-08-24 06:03 EDT, Satyam Kandula CLA
no flags Details
Patch with updated MANIFEST.MF for the test plugin (7.80 KB, patch)
2011-08-29 11:22 EDT, Satyam Kandula CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Satyam Kandula CLA 2011-08-24 04:23:15 EDT
bug 352536 should also be fixed for 3.7.1.
Comment 1 Satyam Kandula CLA 2011-08-24 06:03:40 EDT
Created attachment 202069 [details]
Patch
Comment 2 Satyam Kandula CLA 2011-08-24 06:05:59 EDT
Same code changes as for bug 352536 on R3_7 tag. R3_7_maintenance is not yet created. This patch also has the version change. I have just incremented the version number by 1.
Comment 3 Satyam Kandula CLA 2011-08-24 06:06:10 EDT
Mike, Please review
Comment 4 Michael Rennie CLA 2011-08-29 10:42:59 EDT
The patch looks fine, but if you also plan to back-port the test changes a version update for org.eclipse.test.ant.core is also required.

Adding Dani as PMC review for inclusion in 3.7.1
Comment 5 Satyam Kandula CLA 2011-08-29 11:22:28 EDT
Created attachment 202337 [details]
Patch with updated MANIFEST.MF for the test plugin
Comment 6 Dani Megert CLA 2011-08-30 10:16:16 EDT
+1 for 3.7.1 RC3.
Comment 7 Michael Rennie CLA 2011-08-30 11:20:46 EDT
Applied the last patch to 3.7.1