Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355590 - Cloudio can't work correctly on win7 x64 with jdk x64
Summary: Cloudio can't work correctly on win7 x64 with jdk x64
Status: VERIFIED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Zest (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 23:02 EDT by happytian CLA
Modified: 2015-03-22 06:09 EDT (History)
3 users (show)

See Also:

Attachments
Image of error on win7 x64 (221.65 KB, image/png)
2011-08-23 23:02 EDT, happytian CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description happytian CLA 2011-08-23 23:02:45 EDT 
Created attachment 202050 [details]
Image of error on win7 x64

The words overlap each other on win7 x64 with jdk x64. And you may see the image in the attachment.
    But it works correctly on linux x86 with jdk x86.
Comment 1 Stephan Schwiebert CLA 2011-08-25 05:17:24 EDT 
The bug was related to the analysis of used pixels of each rendered word - their values are slightly different on win7 x64. I modified the related method (actually, a single line of code) and committed it to a fork on GitHub (https://github.com/sschwieb/zest/commit/4522df831a87a8272006927227d84b7d2317b3d2).
Comment 2 Fabian Steeg CLA 2011-08-26 09:28:47 EDT 
Thanks Stephan, pushed your fix to master.

@happytian: see bug 349969, comment 7 for getting the recent version.
Comment 3 happytian CLA 2011-08-28 12:43:04 EDT 
Thanks a lot, it works now.

(In reply to comment #1)
> The bug was related to the analysis of used pixels of each rendered word -
> their values are slightly different on win7 x64. I modified the related method
> (actually, a single line of code) and committed it to a fork on GitHub
> (https://github.com/sschwieb/zest/commit/4522df831a87a8272006927227d84b7d2317b3d2).
Comment 4 Fabian Steeg CLA 2011-08-28 13:04:19 EDT 
(In reply to comment #3)

Thanks for the confirmation. Changing status to VERIFIED.
Comment 5 Alexander Nyßen CLA 2015-03-18 04:59:42 EDT 
Remove IP-log flag from this bugzilla, as contribution can be attributed to Stephan Schwiebert via http://git.eclipse.org/c/gef/org.eclipse.gef4.git/commit?id=9655eebac0163346b4b1b977c6f5976b997a1220 (which contains a comment that refers to this bugzilla).
Comment 6 Alexander Nyßen CLA 2015-03-20 08:52:01 EDT 
Stephan, in order to make our IP log clean, could you please:

1) Turn commit http://git.eclipse.org/c/gef/org.eclipse.gef4.git/commit?id=9655eebac0163346b4b1b977c6f5976b997a1220 into a patch ("git format-patch -1 9655eebac0163346b4b1b977c6f5976b997a1220") and attach it here?

2) Sign the CLA and confirm that your contribution complied with http://www.eclipse.org/legal/CoO.php.

I will then be able to flag only your contribution.
Comment 7 Alexander Nyßen CLA 2015-03-22 06:09:21 EDT 
(In reply to Alexander Nyßen from comment #6)
> Stephan, in order to make our IP log clean, could you please:
> 
> 1) Turn commit
> http://git.eclipse.org/c/gef/org.eclipse.gef4.git/
> commit?id=9655eebac0163346b4b1b977c6f5976b997a1220 into a patch ("git
> format-patch -1 9655eebac0163346b4b1b977c6f5976b997a1220") and attach it
> here?
> 
> 2) Sign the CLA and confirm that your contribution complied with
> http://www.eclipse.org/legal/CoO.php.
> 
> I will then be able to flag only your contribution.

Stephan, as the commit was already approved in the Kepler release log I assume what I outlined here is actually not required.