Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355508 - [server] Locations in Commit JSONs are wrong
Summary: [server] Locations in Commit JSONs are wrong
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.3 M2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 10:03 EDT by Szymon Brandys CLA
Modified: 2011-08-25 11:40 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (13.41 KB, application/octet-stream)
2011-08-25 11:33 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-08-23 10:03:27 EDT 
master 2011, Aug 23

Steps:

1) Clone org.eclipse.orion.client repo to your Orion workspace

2) Navigate to a file and open Git Log for it

3) One of calls is something like:
http://localhost:8080/gitapi/commit/master/file/C/bundles/org.eclipse.orion.client.git/web/orion/git/git-clone-details.js?page=1
which returns the commit list.

4) In the returned JSON check Children and see that all commits have Locations 
/gitapi/commit/[commitId]/file/C/. It should be rather /gitapi/commit/[commitId]/file/C/bundles/org.eclipse.orion.client.git/web/orion/git/git-clone-details.js

The same problem is with ContentLocation and DiffLocation.
Comment 1 Tomasz Zarna CLA 2011-08-25 11:33:13 EDT 
Created attachment 202162 [details]
mylyn/context/zip
Comment 2 Tomasz Zarna CLA 2011-08-25 11:40:09 EDT 
Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=ee118e4f14fba0942c06acbea32b3c2e10ec7b20 and 3 previous commits. Sorry for not squashing them.