Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355463 - [editor] Ruler columns are not skinnable
Summary: [editor] Ruler columns are not skinnable
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: 0.2   Edit
Hardware: Other All
: P3 normal (vote)
Target Milestone: 0.3 M2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 03:20 EDT by Markus Albrecht CLA
Modified: 2011-08-30 17:39 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Albrecht CLA 2011-08-23 03:20:22 EDT 
Build Identifier: Version 0.3M1

With the syntax highlighting possibilities, the editor is already skinnable by applying different Stylesheets.
See also Bug <a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=334212">334212</a>.

Although the ruler columns (line number, annotation, overview) are not skinnable, since there are no CSS-classes used. The styles are set directly from javascript code, where e.g. the background color is hardcoded to white. See file bundles/org.eclipse.orion.client.editor/web/orion/editor/editorFeatures.js and search for "#ffffff".

I suggest to use CSS classes for the ruler columns, where own styles can be defined via a .css file.

Reproducible: Always
Comment 1 Felipe Heidrich CLA 2011-08-23 16:21:17 EDT 
Note the rulers (in textview land) supports this already, see org.eclipse.orion.client.editor/web/examples/textview/demo.js
Comment 2 Markus Albrecht CLA 2011-08-24 04:53:32 EDT 
Yes, you're right! The issue is resolved for me.
Comment 3 Mark Macdonald CLA 2011-08-30 17:39:17 EDT 
Reopening, since we should use class names on the editor's rulers rather than hardcoded styles. This will let you customize the ruler styles by passing an additional stylesheet in the editor's textViewFactory.

Comment 1 points out that you can achieve the same effect by creating the rulers yourself, but that requires overriding all the editor's *rulerFactories. I think the CSS approach will be easier.