Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355442 - Egit is prompting for password for secure store even no secure store is set
Summary: Egit is prompting for password for secure store even no secure store is set
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 16:58 EDT by Ken Leung CLA
Modified: 2011-09-01 11:09 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Leung CLA 2011-08-22 16:58:18 EDT 
Build Identifier: 

On every push, egit will ask for password for a secure store.  The problem is, I never check the option to store the repository username and password in the push dialog.

Reproducible: Always

Steps to Reproduce:
1. Push to upstream with the "store username and password in secure store" option unchecked.
2. push again.
3.
Comment 1 Remy Suen CLA 2011-08-24 06:49:31 EDT 
This behaviour has always perplexed me.
Comment 2 Ken Leung CLA 2011-09-01 10:58:07 EDT 
From the behavior of egit, I think, right now,the secure store is set to be "1 store for all repos" - if the user set a secure store for one project, then egit will always prompt for it because it doesn't know whether the secure store is setup for that particular repo or some other repos.  So I have a suggestion, how about  a distinct secure store for each of the repo so one repo's secure store will not be affecting the others?

I think timestamps can also be implemented to record when is the last push and when is the last time the secure store was used.  If it turns out that the user can finally remember his/her username/password for the remote repo, then egit can prompt for deletion of the secure store?

(this is just suggestions to how to improve it, may not be the best solution thou)
Comment 3 Remy Suen CLA 2011-09-01 11:06:05 EDT 
Getting prompted constantly is pretty annoying but what is more annoying is that I have to uncheck the checkbox every time it shows up. If the password is to be stored in the secure storage then the dialog will never prompt again. Wouldn't it make more sense for the checkbox to be unchecked by _default_?

Then, if a user wants to store the password, the user checks it once and is never bothered again. This is a one-time cost.

On the other hand, the current situation is one in which if the user has no intention to ever store the password, he or she has to consciously unselect this checkbox every single time the remote repository is contacted. This is an N-time cost.
Comment 4 Ken Leung CLA 2011-09-01 11:09:39 EDT 
Agreed, checkbox should not be checked by default.

But I am not sure if someone is going to pick up this bug... I know my colleague was trying to pick it up, but since we are all coop students and tomorrow is our last day, so....