Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355392 - Support Virgo-Jetty from the Eclipse Virgo tooling
Summary: Support Virgo-Jetty from the Eclipse Virgo tooling
Status: RESOLVED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: tooling (show other bugs)
Version: 3.0.0.RELEASE   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 340183 369238 (view as bug list)
Depends on:
Blocks: 368783
  Show dependency tree
 
Reported: 2011-08-22 10:07 EDT by Chris Frost CLA
Modified: 2012-05-08 13:30 EDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Frost CLA 2011-08-22 10:07:45 EDT 
The Jetty variant of Virgo requires some different vm args and so doesn't work from the existing launcher.
Comment 1 Miles Parker CLA 2012-01-16 19:14:03 EST 
OK, this seems a simple matter of changing the args when we create the run configuration for a jetty server.
Comment 2 Miles Parker CLA 2012-03-07 22:46:02 EST 
Alright, with bug 373453 it should be super easy to deal with this. We just need a few pieces of information from the server team:

1. Some way to trivially infer that we're dealing with a Jetty server rather than TomCat. I'm thinking I'll take the obvious route and base that on the existence of a "jetty" directory at installation root. Reasonable?
2. We need the actual vm arguments to use.
Comment 3 Miles Parker CLA 2012-03-13 13:14:02 EDT 
*** Bug 369238 has been marked as a duplicate of this bug. ***
Comment 4 Miles Parker CLA 2012-03-13 13:16:46 EDT 
*** Bug 340183 has been marked as a duplicate of this bug. ***
Comment 5 Chris Frost CLA 2012-03-13 13:21:12 EDT 
Hi,

I'll comment in here once I've figured out what we need.

Chris.
Comment 6 Chris Frost CLA 2012-03-14 10:17:15 EDT 
Hi,

So I've been through the logs to check I'm not missing anything and it's actually simpler than I thought. I have some extra arguments in the Virgo scripts I need to remove.

All that is required is 

-Djetty.home="${KERNEL_HOME}/jetty"

adding to the VM args.

Chris.
Comment 7 Miles Parker CLA 2012-03-20 15:29:54 EDT 
Chris, are you saying that we *shouldn't* include the other args used by Tomcat or that this arg should be in addition to those args?
Comment 8 Miles Parker CLA 2012-03-20 15:58:17 EDT 
OK, I have Jetty launching, but I can't get greenpages to work -- dependency issues. I'm not sure how this could be an issue with how we're launcing it though. Does greenpages currently work under Jetty?
Comment 9 Chris Frost CLA 2012-03-21 06:23:55 EDT 
Hi,

In addition to any other args is all I tried, I guess it could be trimmed down a little though. 

I don't know of any reason why it shouldn't work. Jetty has some issues with TagLibs but Greenpages isn't using TagLibs. What version of Jetty are you trying? I'll have a go.

Chris.
Comment 10 Miles Parker CLA 2012-04-18 15:14:21 EDT 
OK, I'm going to mark this as completed. Please re-open if you experince any issues.