Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355380 - Please provide source for the p2 and ecf bundles
Summary: Please provide source for the p2 and ecf bundles
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.2 M2   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 08:46 EDT by Thomas Hallgren CLA
Modified: 2011-09-01 09:28 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2011-08-22 08:46:47 EDT 
None of the p2 or ecf bundles distributed in the 4.2milestones repository has a corresponding source bundle. Please include them in the repository.
Comment 1 Kim Moir CLA 2011-08-22 14:46:35 EDT 
Andrew, is there a reason the R4_HEAD version of the platform feature doesn't include the generate.feature@org.eclipse.equinox.p2.user.ui.source bits to include the p2 and ecf source bundles? If not, I can attach a patch.
Comment 2 Andrew Niefer CLA 2011-08-22 17:05:44 EDT 
The 4x build won't have the source for the p2 bundles, we should be reusing the source feature from the 3x builds instead of using the generate.feature properties.

I think the problem is not having the other source features which are nested inside p2.user.ui source.  p2.user.ui is marked optional, so a problem satisfying its inclusions is causing it to just be dropped.

Easiest fix is probably to add those features to the e4/releng/org.eclispe.e4.sdk/maps/feature.map file.

I've made this change, I'll leave the bug open for now until we can verify in the next 4x build.
Comment 3 Andrew Niefer CLA 2011-08-24 10:41:52 EDT 
This will be in 4.2 I20110824-1000.

The map file additions did not seem to be sufficient, failed build I20110823-2000 did not contain the source. 

I added a repo2runnable call to transform the mirror we had of the SDK metadata