Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355363 - [M2x IDE Integration] TypeSystemImpl attribute for XtendJob
Summary: [M2x IDE Integration] TypeSystemImpl attribute for XtendJob
Status: CLOSED WONTFIX
Alias: None
Product: Sphinx
Classification: Automotive
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.7.0   Edit
Assignee: Stephan Eberle CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 07:00 EDT by Ali AKAR CLA
Modified: 2021-07-14 02:14 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ali AKAR CLA 2011-08-22 07:00:18 EDT
Add an attribute of type TypeSystemImpl and make it possible to set is by the users. When this attribute is null (not set), the job should create the TypeSystemImpl lazily.
Comment 1 Ali AKAR CLA 2011-08-22 07:16:55 EDT
Fixed.
Comment 2 Stephan Eberle CLA 2011-08-23 02:52:40 EDT
Ok for the new setter method, but we must never refer to the implementation classes in such cases. Instead the interface, i.e., org.eclipse.xtend.expression.TypeSystem, should be used. The only exception to this rule is the location where you create a new instance of TypeSystemImpl on the fly. 

So could you kindly revise the code accordingly?
Comment 3 Stephan Eberle CLA 2011-09-22 07:19:32 EDT
The support for custom TypeSystem instances has meanwhile been implemented in a slightly different way. See bug #357813.
Comment 4 Balazs Grill CLA 2021-07-14 02:14:20 EDT
Mass-closing Resolved tickets