Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355352 - [Table][Tree] DefaultSelection events firied when clicking different cells
Summary: [Table][Tree] DefaultSelection events firied when clicking different cells
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.5 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 05:35 EDT by Tim Buschtoens CLA
Modified: 2011-09-26 05:44 EDT (History)
2 users (show)

See Also:


Attachments
patch for HEAD (6.38 KB, patch)
2011-08-23 06:06 EDT, Tim Buschtoens CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2011-08-22 05:35:42 EDT
Usually a double click is only fired when clicking the same pixel twice. However the table and tree are allowing the mouse to be moved within an item, e.g. on different cells, which can can cause unwanted doubleclick events.
Comment 1 Tim Buschtoens CLA 2011-08-23 06:06:00 EDT
Created attachment 201984 [details]
patch for HEAD

This checks the horizontal offset to be no more than +/- 8 pixels. With this value its unlikely to hit two different cells in a short enough time, but still possible to execute a doubleclick on a touch-device such as iPad.
Comment 2 Tim Buschtoens CLA 2011-08-23 06:07:12 EDT
Commited patch to HEAD.
Comment 3 Tim Buschtoens CLA 2011-08-23 06:57:27 EDT
Patch committed to v14_Tree_Table_Merge branch also.
Comment 4 Tim Buschtoens CLA 2011-08-30 04:00:57 EDT
Apparently its still possible to produce "wrong" doubleclicks, even across larger horizontal and vertical distances.
Comment 5 Tim Buschtoens CLA 2011-09-26 05:44:15 EDT
The original fix only solved the issue for DefaultSelection events, not actual doubleclick events. However, since this is a global issue, i opend another bug for this: Bug 358858