Description Balazs Varnai 2011-08-22 05:03:55 EDT

Build Identifier: I20110613-1736

IAdaptable implementation in org.eclipse.xtext.ui.editor.XtextEditor should never return something that is not instance of OutlinePage. Check the contract of IAdaptable.getAdapter().

Code sample as in 2.1:

public Object getAdapter(Class adapter) {
if (IContentOutlinePage.class.isAssignableFrom(adapter)) {
return getContentOutlinePage();
}
return super.getAdapter(adapter);
}

In case of multiple parts implementing IContentOutlinePage, actions could fail due to the misleading return of adapt.

My suggestion:

public Object getAdapter(Class adapter) {
  if (org.eclipse.xtext.ui.editor.outline.impl.OutlinePage.class.isAssignableFrom(adapter)) {
     return getContentOutlinePage();
   }
   return super.getAdapter(adapter);
}






Reproducible: Always

Steps to Reproduce:
Integration issue, check code.