Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355243 - JSP Fragment Taglib content assist ModelQueryExtension
Summary: JSP Fragment Taglib content assist ModelQueryExtension
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 12:47 EDT by Chris Stodden CLA
Modified: 2011-08-23 15:42 EDT (History)
2 users (show)

See Also:
thatnitind: review+

Attachments
patch (4.26 KB, patch)
2011-08-22 13:10 EDT, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Stodden CLA 2011-08-19 12:47:02 EDT 
Build Identifier: I20110613-1736

Should the TaglibModelQueryExtension be enabled for jspfragmentsource contentType.  Just noticing that no JSP taglib proposals appear in pagefragments.

Reproducible: Always

Steps to Reproduce:
1.  Create web project
2.  Create page fragment
3.  Associate some taglib via namespace reference
4.  Within page fragment ctrl+space only see the HTML proposals.
Comment 1 Nitin Dahyabhai CLA 2011-08-19 13:06:13 EDT 
I think you're right; the ModelQueryExtensionRegistry's not using the content type hierarchy.
Comment 2 Nick Sandonato CLA 2011-08-22 13:10:51 EDT 
Created attachment 201940 [details]
patch
Comment 3 Nitin Dahyabhai CLA 2011-08-22 16:06:57 EDT 
Approved.  Don't forget to also update the extension point schema to instruct on *how* to specify those multiple content type IDs.
Comment 4 Nick Sandonato CLA 2011-08-22 16:26:02 EDT 
Code released to 3_3_maintenance and HEAD.
Comment 5 Chris Stodden CLA 2011-08-23 15:42:44 EDT 
Thanks!