Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355223 - [modeling] rename classes to follow standard naming convention
Summary: [modeling] rename classes to follow standard naming convention
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.9   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 355025
  Show dependency tree
 
Reported: 2011-08-19 09:42 EDT by Steffen Pingel CLA
Modified: 2011-12-06 12:11 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-08-19 09:42:26 EDT
The standard project naming convention requires CamelCase for abbreviations, i.e.: EmfStructureBridge (instead of EMFStructureBridge), IModelUiProvider (instead of IModelUIProvider).

"Mylyn" should not be used in class names, instead use identifiers that describe the purpose of a class, e.g. InterestDecoratorProvider (instead of MylynDecoratorProvider).
Comment 1 Miles Parker CLA 2011-08-19 16:10:03 EDT
https://github.com/MilesParker/mylyn.incubator/commit/1c82a17b7ff5bc1f0257332185ef3845c1ac1894

FWVeryLittleIW, naturally modeling tools follow the opposite convention :) so that feels 'correct' to me, but it should have been obvious that Mylyn uses the other one.

>"Mylyn" should not be used in class names, instead use identifiers that describe the purpose of a class, e.g. InterestDecoratorProvider (instead of MylynDecoratorProvider).

https://github.com/MilesParker/mylyn.incubator/commit/47f35a4558865b8b760eaef90bb82829b1875237

Again, FWVLIW, here I was using Mylyn as a modifier to indicate the purpose of the class, which is to provide a generic IDecoratorProvider for all Mylyn implementations. But ContextDecoratorProvider describes it much better I think.