Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355211 - CodetemplatesGeneratorFragment does not work without JDT
Summary: CodetemplatesGeneratorFragment does not work without JDT
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: SR2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 08:31 EDT by Hendrik Eeckhaut CLA
Modified: 2017-09-19 18:14 EDT (History)
2 users (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
stacktrace (113.54 KB, text/plain)
2011-08-19 08:32 EDT, Hendrik Eeckhaut CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hendrik Eeckhaut CLA 2011-08-19 08:31:26 EDT 
Build Identifier: 20110615-0604

CodetemplatesGeneratorFragment seems to be independent of JDT, but when I run our xtext plugin without JDT, injection fails for the org.eclipse.xtext.ui.codetemplates.ui plugin.



Reproducible: Always

Steps to Reproduce:
1. Create xtext project independent of JDT
2. Add CodetemplatesGeneratorFragment to MWE2 workflow
3. Run project without JDT plugins
Comment 1 Hendrik Eeckhaut CLA 2011-08-19 08:32:35 EDT 
Created attachment 201789 [details]
stacktrace

Stacktrace
Comment 2 Hendrik Eeckhaut CLA 2011-08-30 08:12:57 EDT 
When I override following bindings in the UI modules (CodetemplatesUiModule and SingleCodetemplateUiModule) it works fine without JDT:

@Override
public Class<? extends IResourceForEditorInputFactory> bindIResourceForEditorInputFactory() {
	return ResourceForIEditorInputFactory.class;
}
	
@Override
public Class<? extends IResourceSetProvider> bindIResourceSetProvider() {
	return SimpleResourceSetProvider.class;
}

@Override
public com.google.inject.Provider<org.eclipse.xtext.resource.containers.IAllContainersState> provideIAllContainersState() {
	return org.eclipse.xtext.ui.shared.Access.getWorkspaceProjectsState();
}

Two questions:
1. Is there any reason why the codetemplates.ui plugin depends on JDT?
2. Is it possible to override these bindings without changing code in the codetemplates.ui plugin?

Thanks,
Hendrik.
Comment 3 Holger Schill CLA 2011-09-14 10:40:57 EDT 
There was no special reason why the codetemplates.ui plugin depended on JDT. We removed the dependency by adding your suggested bindings. No need to have custom bindings anymore.


pushed to master.
Comment 4 Karsten Thoms CLA 2017-09-19 18:04:50 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 18:14:49 EDT 
Closing all bugs that were set to RESOLVED before Neon.0