Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355151 - WTP builds are leaving empty directories behind after signing
Summary: WTP builds are leaving empty directories behind after signing
Status: ASSIGNED
Alias: None
Product: WTP Releng
Classification: WebTools
Component: releng (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Carl Anderson CLA
QA Contact: Carl Anderson CLA
URL:
Whiteboard:
Keywords:
Depends on: 350114
Blocks:
  Show dependency tree
 
Reported: 2011-08-18 15:23 EDT by David Williams CLA
Modified: 2011-08-18 16:05 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-08-18 15:23:13 EDT
Carl and I noticed there are about 1000 empty directories in our webtools signing directory. This is surprising since 1) we should be cleaning them up, and 2) if we don't, seems like the webmasters (cronjob) should be (I think they have one that cleans up on files older than 14 days, or something). 

This has been happening for about 2 months, apparently. I wonder if related to when we got "permission" set so wtpBuild id could sign? 

We should check out logs, to see if any interesting messages have been being logged when we try to remove it? Something might have changed in infrastructure (since NSF) that it is just not ready to remove it when we try ... so, leaves it there, and we never go back to clean up?

In any case, just wanted to document the issue here.
Comment 1 David Williams CLA 2011-08-18 15:26:33 EDT
Webmasters, 

including you on CC for your awareness. As far as we currently know, we do not need you to do anything ... my first guess (and yours :) is that we have some bug in our scripts, which we will investigate. 

But, wanted to include you on CC, just in case there was some larger issue you wanted to be made aware of.
Comment 2 Carl Anderson CLA 2011-08-18 15:58:27 EDT
I found an issue with our scripts - as of 6/25, we started making a signing directory to put content in there, but it doesn't appear that we are cleaning it up properly.
Comment 3 Carl Anderson CLA 2011-08-18 16:04:44 EDT
I committed a fix for this in scripts/build/signjars.xml - after reading up on Ant, if I understand the delete command properly, we want:

<delete includeemptydirs="true" deleteonexit="true">

I will leave this bug open for a little bit while I verify that this does fix the problem.

I also deleted almost all of the directories in 
/opt/public/download-staging.priv/webtools
(I left the libra directory and a directory owned by genie .)
Comment 4 Carl Anderson CLA 2011-08-18 16:05:39 EDT
For historical purposes, bug 350114 was the bug used to modify how signing is done in the webtools build.