Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355046 - tycho-versions-plugin should ignore leading/trailing whitespaces in pom
Summary: tycho-versions-plugin should ignore leading/trailing whitespaces in pom
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tobias Oberlies CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 05:33 EDT by Matthias Gradl CLA
Modified: 2021-04-28 16:54 EDT (History)
0 users

See Also:


Attachments
Proposal to ignore whitespace that surrounds values in GAV (9.96 KB, patch)
2011-08-18 09:41 EDT, Matthias Gradl CLA
t-oberlies: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Gradl CLA 2011-08-18 05:33:12 EDT
Build Identifier: 

When updating the specified version in a multimodule Tycho project using tycho-versions-plugin, it is checked whether the module should be updated. The update is only applied if the module is linked to the reactor using the parent specification. 

Now, if there is whitespace surrounding any of the GAV values specifying the parent no match will be found and the version change is not applied.

As whitespaces are illegal characters in Maven groupId or artifactId anyway, but quite in common use to format an XML file, we should only used the trimmed values from the pom, like standard Maven also does.

Reproducible: Always
Comment 1 Matthias Gradl CLA 2011-08-18 09:41:22 EDT
Created attachment 201718 [details]
Proposal to ignore whitespace that surrounds values in GAV
Comment 2 Tobias Oberlies CLA 2011-08-18 10:50:07 EDT
Fixed with d42e4b1. Thank you for the patch!