Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355035 - [Model Explorer] minor changes in the search dialog
Summary: [Model Explorer] minor changes in the search dialog
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 04:11 EDT by Mathieu Velten CLA
Modified: 2013-05-31 12:37 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Velten CLA 2011-08-18 04:11:04 EDT
The biggest problem was performance : compute a search on a big model takes a lot of time, so do it for each key typed does not really work with big models.

What I did :
- change the dialog by replacing the ok button with a "Launch search"
- add a cancelable monitor during search
- make the dialog non-modal so we can access the properties view for example without leaving the search dialog

There is still something that I don't really know which option is the best :
currently when hitting next the current selection in the model explorer is retrieved and the next element in the search results is calculated from there.
it can be weird with a non modal dialog since we can change the selection (if it doesn't find the current selection in the search results it go back to the beginning).

I suggest to just use an integer to store the current search index.

I am commiting this so you can see my work and comment.
Comment 1 Camille Letavernier CLA 2013-05-31 12:37:38 EDT
The quick search is disabled and has been replaced with a proper search dialog.

I close this task.