Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355030 - WorkbenchStatusDialogManager.setSupportAreaProvider(AbstractStatusAreaProvider) doesn't work
Summary: WorkbenchStatusDialogManager.setSupportAreaProvider(AbstractStatusAreaProvide...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Krzysztof Daniel CLA
QA Contact: Krzysztof Daniel CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 03:09 EDT by Alexey Romanov CLA
Modified: 2011-12-31 07:12 EST (History)
1 user (show)

See Also:


Attachments
Patch proposition (1.19 KB, patch)
2011-12-30 15:15 EST, Krzysztof Daniel CLA
no flags Details | Diff
mylyn/context/zip (35.25 KB, application/octet-stream)
2011-12-30 15:15 EST, Krzysztof Daniel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Romanov CLA 2011-08-18 03:09:45 EDT
Build Identifier: 

This method is defined as 

public void setSupportAreaProvider(AbstractStatusAreaProvider provider) {
	manager.setProperty(IStatusDialogConstants.CUSTOM_SUPPORT_PROVIDER,
		provider);
}

However, IStatusDialogConstants.CUSTOM_SUPPORT_PROVIDER isn't used anywhere outside this method (according to References > Workspace search). Presumably, it should be checked in SupportTray.getSupportProvider()

Reproducible: Always

Steps to Reproduce:
Create an Eclipse application with a custom status handler and call WorkbenchStatusDialogManager.setSupportAreaProvider(AbstractStatusAreaProvider) in your configureStatusDialog(WorkbenchStatusDialogManager) method.
Comment 1 Krzysztof Daniel CLA 2011-12-30 15:15:01 EST
Created attachment 208881 [details]
Patch proposition

This is a patch that solves this problem (introduced by fix for bug 298748).
Comment 2 Krzysztof Daniel CLA 2011-12-30 15:15:05 EST
Created attachment 208882 [details]
mylyn/context/zip
Comment 3 Krzysztof Daniel CLA 2011-12-30 15:18:31 EST
Alexey,
would you be able to verify that this patch works for you?

Note that you can workaround the problem by setting the support provider via org.eclipse.jface.util.Policy#setErrorSupportProvider.
Comment 4 Krzysztof Daniel CLA 2011-12-31 06:58:48 EST
I have released the fix and tests
commit d1162a612d74a6fe538ab781e184394cda644b2c
Comment 5 Alexey Romanov CLA 2011-12-31 07:12:48 EST
Yes, it works for me.