Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355020 - User should be able to select Mozilla browser for use with Visual Editor
Summary: User should be able to select Mozilla browser for use with Visual Editor
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Yun Feng Ma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-17 22:03 EDT by Tony Chen CLA
Modified: 2017-02-23 14:20 EST (History)
2 users (show)

See Also:

Attachments
Patch (6.51 KB, patch)
2011-08-22 04:07 EDT, Yun Feng Ma CLA 		lasher: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chen CLA 2011-08-17 22:03:45 EDT 
In linux, user needs to be able to use Visual Editor with Mozilla which is default browser. 

In windows, the default browser for VE is IE, user needs to be able to change it (through preference page) Mozilla.
Comment 1 Will Smythe CLA 2011-08-17 22:44:41 EDT 
In RBD 8, the default VE browser on Windows was Firefox. I think Firefox should be the default in EDT as well.

See the following Eclipse tip ...
http://www.eclipse.org/swt/faq.php#howdetectmozilla

This is consistent with my understanding... SWT Browser (which we use, right?) will look for XUL runner libraries "automatically", assuming SWT.MOZILLA is set on construction of the Browser. 

So, maybe this just works? ;)
Comment 2 Yun Feng Ma CLA 2011-08-22 04:07:40 EDT 
Created attachment 201897 [details]
Patch

With this patch, the VE can use XULRunner as the render engine.

Below are the steps to enable XULRunner in EDT in Windows:
1) Download XUNRuner from http://releases.mozilla.org/pub/mozilla.org/xulrunner/releases/
2) Unzip the XUNRunner to a folder
3) Add below line to the -vmargs section in eclipse.ini
   -Dorg.eclipse.swt.browser.XULRunnerPath=PATH_TO_XULRunner


Now VE uses IE as the default render engine to avoid the "no xulrunner configured" error message when user start EDT first time.
Comment 3 Tony Chen CLA 2011-08-22 07:02:54 EDT 
code committed
Comment 4 Yun Feng Ma CLA 2011-08-23 05:45:13 EDT 
Resolved. Please verify. Thanks.
Comment 5 Tony Chen CLA 2011-10-28 02:42:08 EDT 
Verified. 

A design change is going to happen for which default browser to use, details are in bug 361770, bug 362128, bug 362132.