Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354987 - assignee field not editable
Summary: assignee field not editable
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: Frank Becker CLA
QA Contact: Frank Becker CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 337245
  Show dependency tree
 
Reported: 2011-08-17 13:34 EDT by Steffen Pingel CLA
Modified: 2011-08-25 15:51 EDT (History)
0 users

See Also:


Attachments
people section (6.44 KB, image/png)
2011-08-17 13:34 EDT, Steffen Pingel CLA
no flags Details
mylyn/context/zip (4.91 KB, application/octet-stream)
2011-08-22 15:02 EDT, Frank Becker CLA
no flags Details
screenshot of bug# 168204 (74.69 KB, image/jpeg)
2011-08-24 00:58 EDT, Frank Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-08-17 13:34:26 EDT
1. Open https://bugs.eclipse.org/bugstest/show_bug.cgi?id=199345
2. Try to reassign bug

The assignee field is not editable even though it is in the web interface.
Comment 1 Steffen Pingel CLA 2011-08-17 13:34:48 EDT
Created attachment 201658 [details]
people section
Comment 2 Frank Becker CLA 2011-08-22 13:38:57 EDT
Steffen,

did you have the same problem in the Mylyn test Bugzilla?

I can not reproduce this with

http://mylyn.eclipse.org/bugshead
and
http://mylyn.eclipse.org/bugs36

Maybe this is related to the bugzilla 4.0 with 3.6 workflow.

Try to test this Sunday!
Comment 3 Frank Becker CLA 2011-08-22 15:02:25 EDT
Steffen,

I have fixed this for 3.7 (master).

Can you verify and tell me how to apply this to the 3.6 branch!
Comment 4 Frank Becker CLA 2011-08-22 15:02:27 EDT
Created attachment 201945 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2011-08-22 17:41:50 EDT
I have applied the fix to the e_3_7_m_3_6 branch. It now works for unresolved bugs.

In the web interface I can also reassign resolved bugs on the Eclipse Bugzilla 4.0. Could we enable that in the task editor for migrated Bugzilla 4.0 repositories as well?
Comment 6 Frank Becker CLA 2011-08-23 15:11:13 EDT
(In reply to comment #5)
> I have applied the fix to the e_3_7_m_3_6 branch. It now works for unresolved
> bugs.
> 
> In the web interface I can also reassign resolved bugs on the Eclipse Bugzilla
> 4.0. Could we enable that in the task editor for migrated Bugzilla 4.0
> repositories as well?

Sorry, I can not reproduce this with my bootstrap workspace for 3.7. see https://bugs.eclipse.org/bugstest/show_bug.cgi?id=213110
Comment 7 Steffen Pingel CLA 2011-08-23 17:40:09 EDT
That bug is reopened which seems to work fine. Can you try reassigning this bug: 168204: https://bugs.eclipse.org/bugstest/show_bug.cgi?id=168204 ?
Comment 8 Frank Becker CLA 2011-08-24 00:57:18 EDT
(In reply to comment #7)
> That bug is reopened which seems to work fine. Can you try reassigning this
> bug: 168204: https://bugs.eclipse.org/bugstest/show_bug.cgi?id=168204 ?

Yes I use this bug to make sure, that the reopen is not only in the list of operation. I test that the reopen works!
Comment 9 Frank Becker CLA 2011-08-24 00:58:49 EDT
Created attachment 202051 [details]
screenshot of bug# 168204
Comment 10 Steffen Pingel CLA 2011-08-24 04:59:29 EDT
Sorry, if I was not clear: If I open bug 168204 in the web interface I can edit the assignee. If I open the same bug in the task editor I can not edit the assignee. That's what I would like to get fixed.
Comment 11 Frank Becker CLA 2011-08-24 15:30:03 EDT
(In reply to comment #10)
> Sorry, if I was not clear: If I open bug 168204 in the web interface I can edit
> the assignee. If I open the same bug in the task editor I can not edit the
> assignee. That's what I would like to get fixed.

OK, now I see the problem!

addValidOperationsBefore4 has the following lines:


		if (status == BUGZILLA_REPORT_STATUS.NEW || status == BUGZILLA_REPORT_STATUS.ASSIGNED
				|| status == BUGZILLA_REPORT_STATUS.REOPENED || status == BUGZILLA_REPORT_STATUS.UNCONFIRMED) {
			if (bugzillaVersion.compareMajorMinorOnly(BugzillaVersion.BUGZILLA_3_0) <= 0) {
				// old bugzilla workflow is used
				addOperation(bugReport, BugzillaOperation.reassign);
				addOperation(bugReport, BugzillaOperation.reassignbycomponent);
			} else {
.
.
.

Should we remove the whole block? (see bug#355737)
Comment 12 Frank Becker CLA 2011-08-24 16:31:45 EDT
patch created!
Comment 13 Steffen Pingel CLA 2011-08-25 05:03:14 EDT
Now the assignee field is editable for any bug in Bugzilla > 3.0. If that's generally the case I'm fine with the proposed changes.
Comment 14 Steffen Pingel CLA 2011-08-25 05:04:42 EDT
I have cherry picked the latest commit onto the 3_6_x branch.
Comment 15 Frank Becker CLA 2011-08-25 15:51:46 EDT
(In reply to comment #13)
> Now the assignee field is editable for any bug in Bugzilla > 3.0. If that's
> generally the case I'm fine with the proposed changes.

Eclipse.org use 3.6 and you can edit the field in resolved bugs. So I think it is OK!

(In reply to comment #14)
> I have cherry picked the latest commit onto the 3_6_x branch.

So I close this bug!