Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354911 - EGit not using compare APIs from commit viewer.
Summary: EGit not using compare APIs from commit viewer.
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 354474
  Show dependency tree
 
Reported: 2011-08-17 03:45 EDT by Laurent Goubet CLA
Modified: 2011-10-04 06:27 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Goubet CLA 2011-08-17 03:45:45 EDT 
As mentionned in the subject of this bug, EGit is creating its own custom implementation of the TypedElement interface when using the "right-click > Compare with Version in Ancestor" action from the commit viewer on a changed file (bottom right of the history view).

This means that the files will _always_ be compared as text instead of using the proper comparison engine, effectively disabling tools such as EMF Compare (that provides custom comparison engines for EMF models).

Furthermore, this does not make use of the ModelProviders in order to determine whether the "changed file" is part of a logical model before comparing it. This second issue makes this bug a blocker for bug 354474.
Comment 1 Benjamin Muskalla CLA 2011-10-01 07:06:10 EDT 
I suspect the same underlying problem as with bug 354923 and cannot reproduce with the described steps.
Comment 2 Laurent Goubet CLA 2011-10-03 02:54:53 EDT 
Benjamin,

see my bug 354923, comment 2 ; This issue seems fixed on master.
Comment 3 Benjamin Muskalla CLA 2011-10-04 06:27:36 EDT 
Great!