Community
Participate
Working Groups
AnyException's IR was changed from package egl.core to egl.lang. It needs to be updated in the JS runtime. I'm going to update its package, but I'm leaving this open because I don't know if any other changes are necessary in the runtime, due to changes in the IRs (e.g. its super type in the runtime is egl.jsrt.Record, but in the IRs it's an external type that extends EglAny).
There were a lot of other problems with the other runtime exceptions so I've updated their packages, super type package, and all references. I removed those that no longer exist in EDT (such as LobProcessingException) and added missing exception types (such as InvalidPatternException). Deployment code has been updated to include the correct set of .js files. NOTE: RuntimeException has been removed in EDT, and specific exception types should be thrown instead. There were many, many occurrences of RuntimeException being thrown, so I've replaced each one with "TODO: make an exception for this". There were ~150 places throwing this exception type that need to be updated. If a new Exception type needs to be added to the eglars, please check with Matt Heitz.
Justin, After talking with Joe and Matt yesterday, we concluded the best thing to do with exceptions in the JS RT was to bring back the RuntimeException.js part but update its implementation to throw AnyException instead of the old RuntimeException (since that has been dropped from EDT). Doing this restores the ability to differentiate exceptions based on the message id while also being consistent with EDT's decision to treat all runtime exceptions as AnyExceptions. I've finished this work and will be committing it under https://bugs.eclipse.org/bugs/show_bug.cgi?id=352122 Note that this doesn't affect any runtime logic that throws -- or should throw -- other exception classes. Joe shared your concern that there may be some places where a more specific exception class would be more appropriate; for now, the thinking is that we'll fix those as they come up..... It's up to you whether you want to keep this bug open as a reminder to review the code for these things.
Justin, I think we're done with this one; please re-open (with comments) if there's more that needs to be covered...thanks!
Closing
