Community
Participate
Working Groups
Currently there are a number of custom properties that are contributed to help style the CTabFolder. These property names should be refactored to reflect that they are contributed and not part of the standard CSS2 selector list. The initial proposed format is: tab-renderer => -swt-tabrender unselected-tabs-color => -swt-unselected-tabs-color
I would go even further and prefix all and everything we support with -swt because we e.g. don't respect all the different length values (pt,em,...)
Bogdan, is this something we need to address before we send everybody running for the style sheets? We also have properties like single and simple that probably aren't part of CSS. PW
*** Bug 325580 has been marked as a duplicate of this bug. ***
We should definately fix all of our properties none of them is compatible with the Web-CSS e.g. we can't support px, em on font-size, our background-color definition (with gradients) is totally different to the Web one, ...
Pushed as commit aeacb33f1e345f110ade10a788da98d0569d8dbb. Added deprecated tag to <property-name> element. Deprecated existing custom properties and re-added with prefix '-swt-' or '-e4-' (org.eclipse.ui.workbench's "perspective-keyline-color"). Add some more detail to property.handler extension point. Use of deprecated properties logs a message using org.eclipse.core.runtime's log using the internal RuntimeLog class. This isn't ideal, I know, but from other bugs, it seemed somewhat desirable that the CSS support non-OSGi situations.
After the CSS refactoring, the whole CSS (dynamic) theme switching of the e4 contacts demo (in platform.ui, project org.eclipse.e4.demo.contacts) does not work anymore. Invoking engine.setTheme(themeId, true) in class SwitchThemeHandler with correct css theme ids has no effect anymore (it was working perfectly in 4.2 M5) Please tell me either what to do with the contacts demo or make the theming backwards compatible (in terms of workflow) with 4.2 M5
Re: bug 373939 comment 5 Kai: I've just tested the contacts demo and theme switching works with no issue. These changes did not touch the theme engine or theme manager. Do you have anything coming up in your logs?
@Brian, after another pull of platform.ui and platform.runtime, the theme switching is working again! I have no idea why it was not working 30 minutes ago since I deleted everything completely (physically) and got a freah clean master from both repos. But anyway, everything is fine now, thanks again.
Marking as resolved.
Verified in I20120503-1800
