Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354727 - Duplicated refactoring tests
Summary: Duplicated refactoring tests
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-refactoring (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 8.1.0   Edit
Assignee: Sergey Prigogin CLA
QA Contact: Sergey Prigogin CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-15 08:57 EDT by Lukas Felber CLA
Modified: 2012-05-22 20:41 EDT (History)
1 user (show)

See Also:

Attachments
fix (removal of duplicate tests) (5.39 KB, patch)
2011-08-15 08:58 EDT, Lukas Felber CLA 		cdtdoug: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Felber CLA 2011-08-15 08:57:20 EDT 
Build Identifier: I20110613-1736

ExtractFunctionTestSuite contains 7 duplicated tests.

Reproducible: Always

Steps to Reproduce:
duplicates are located (in org.eclipse.cdt.ui.tests/resources/refactoring/ExtractExpression.rts):
 - Extract int constant
 - Extract char constant
 - Extract boolean true constant
 - Extract boolean false constant
 - Extract expresion with typdef Bug 331985
 - Extract macro

and (in org.eclipse.cdt.ui.tests/resources/refactoring/ExtractMethod.rts)
 - Bug 248622: Extract function fails to extract several expressions; Selection at the end
 - Bug 248622: Extract function fails to extract several expressions; Selection in the middle
2.
3.
Comment 1 Lukas Felber CLA 2011-08-15 08:58:25 EDT 
Created attachment 201492 [details]
fix (removal of duplicate tests)

here the fix.
Comment 2 Lukas Felber CLA 2011-08-15 09:00:28 EDT 
(In reply to comment #0)

>  - Extract expresion with typdef Bug 331985

My mistake her. "Extract expresion with typdef Bug 331985" is no duplicate (and also not removed in the patch).
Comment 3 Sergey Prigogin CLA 2011-12-14 15:26:04 EST 
Fixed. Lukas, please verify. Thanks.
Comment 4 CDT Genie CLA 2011-12-14 16:23:03 EST 
*** cdt git genie on behalf of Sergey Prigogin ***

    Bug 354727. Removed duplicated refactoring tests.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=07c85789428dab73bc6f8b8280a10d99560d74fb