Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354635 - OnTheFlyCompiler fails on Windows or if OS temp folder contains spaces
Summary: OnTheFlyCompiler fails on Windows or if OS temp folder contains spaces
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-12 11:21 EDT by Kai Kreuzer CLA
Modified: 2017-09-19 18:03 EDT (History)
3 users (show)

See Also:
sebastian.zarnekow: juno+

Attachments
proposed patch (2.38 KB, patch)
2011-08-12 11:22 EDT, Kai Kreuzer CLA 		sven.efftinge: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Kreuzer CLA 2011-08-12 11:21:36 EDT 
Build Identifier: 20110615-0604

The OnTheFlyCompiler creates invalid classpath URL (using \ instead of /) on Windows and thus fails with an exception.

Furthermore, it constructs an illegal argument string for the Eclipse compiler, if the OS temp directory contains spaces (like on WindowsXP "Documents and Settings...").


Reproducible: Always

Steps to Reproduce:
1. Execute the unit tests of the domain model example on WindowsXP.
Comment 1 Kai Kreuzer CLA 2011-08-12 11:22:22 EDT 
Created attachment 201404 [details]
proposed patch
Comment 2 Sebastian Zarnekow CLA 2011-11-09 14:50:33 EST 
Not 2.1
Comment 3 Kai Kreuzer CLA 2011-11-09 15:06:49 EST 
Hi Sebastian,

Do you mean "not occuring on 2.1" or "won't be fixed on 2.1.x"?
If the latter, might I ask why? It is a completely broken feature if you work on Windows and the fix is very straight forward (and the proposed patch already 3 months old...)

Would be great if you could reconsider this as patching every release manually is very tedious.
Comment 4 Sebastian Zarnekow CLA 2011-11-09 15:08:03 EST 
I meant it didn't make it into 2.1.

Will reconsider for 2.1.1
Comment 5 Sven Efftinge CLA 2011-11-10 03:09:02 EST 
We would have to update the IP log and we want to put the 2.1.1 release out tomorrow. Sorry for the delay, we'll apply it for 2.2 to be released in a couple of weeks.
Comment 6 Sven Efftinge CLA 2011-11-17 11:49:26 EST 
pushed. 
Unfortunately, I couldn't use git am since the patch was outdated. Thank you.
Comment 7 Kai Kreuzer CLA 2011-12-07 06:58:31 EST 
Just FTR: The compiler has been removed in Xtext 2.2, there is now a feature request to re-introduce it: https://bugs.eclipse.org/bugs/show_bug.cgi?id=365870
Comment 8 Karsten Thoms CLA 2017-09-19 17:52:24 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 9 Karsten Thoms CLA 2017-09-19 18:03:05 EDT 
Closing all bugs that were set to RESOLVED before Neon.0