Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354630 - Test failures in R37x builds
Summary: Test failures in R37x builds
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-12 10:45 EDT by DJ Houghton CLA
Modified: 2011-08-15 10:47 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2011-08-12 10:45:33 EDT 
There are some test failures in the latest maintenance build related. The change in bug 348455 has surfaced this problem. We have code in RepositoryAction#setRepositoryCount which is accessing the preference node after it has been removed, thus the error.


java.lang.IllegalStateException: Preference node "http:__eclipse.org_eclipse_updates_RemoveRepositoryActionTest" has been removed.
	at org.eclipse.core.internal.preferences.EclipsePreferences.checkRemoved(EclipsePreferences.java:158)
	at org.eclipse.core.internal.preferences.EclipsePreferences.remove(EclipsePreferences.java:863)
	at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.RepositoryAction.setRepositoryCount(RepositoryAction.java:219)
	at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.RepositoryAction.removeFromSelf(RepositoryAction.java:174)
	at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.RemoveRepositoryAction.execute(RemoveRepositoryAction.java:38)
	at org.eclipse.equinox.p2.tests.touchpoint.eclipse.RemoveRepositoryActionTest.testInvalidEnablement(RemoveRepositoryActionTest.java:59)
Comment 2 DJ Houghton CLA 2011-08-12 11:23:29 EDT 
.
Comment 3 DJ Houghton CLA 2011-08-12 11:39:02 EDT 
Actually I'm going to change this differently and set the repository count before removing the repository. Reopening to make the change.