Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354586 - API Errors/Warnings severity fishy
Summary: API Errors/Warnings severity fishy
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M2   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-12 04:05 EDT by Dani Megert CLA
Modified: 2011-08-24 02:17 EDT (History)
1 user (show)

See Also:

Attachments
Fix (3.51 KB, patch)
2011-08-22 07:22 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-12 04:05:23 EDT 
N20110810-2000.

Something is fishy when determining the severity of an API Errors/Warnings problem.

1. start new workspace
2. set 'Missing execution environment descriptions' to 'Warning'
3. checkout 'org.eclipse.ui.navigator' from HEAD
==> WRONG: error after build due to missing EE description
4. open the 'API Errors/Warnings' property page for the project
==> OK: the page  indicates that the problem should be reported as warning
Comment 1 Michael Rennie CLA 2011-08-15 09:10:14 EDT 
Seems very similar to bug 315417, probably just need to add the preference identifier to the list of preferences checked for in ApiPlugin#hasProjectSettings method.
Comment 2 Dani Megert CLA 2011-08-15 09:15:02 EDT 
(In reply to comment #0)
> N20110810-2000.
> 
> Something is fishy when determining the severity of an API Errors/Warnings
> problem.
> 
> 1. start new workspace
> 2. set 'Missing execution environment descriptions' to 'Warning'
> 3. checkout 'org.eclipse.ui.navigator' from HEAD
> ==> WRONG: error after build due to missing EE description
> 4. open the 'API Errors/Warnings' property page for the project
> ==> OK: the page  indicates that the problem should be reported as warning

probably.
Comment 3 Dani Megert CLA 2011-08-22 07:20:53 EDT 
The store sequence in which the preferences are fetched is wrong. This has already been mentioned in bug 315417 but since it was late in the game we made a very conservative fix.

It's time now for the right fix i.e. revert the changes for bug 315417 and use the correct store sequence.

The attache patch also fixed bug 344417.
Comment 4 Dani Megert CLA 2011-08-22 07:22:46 EDT 
Created attachment 201908 [details]
Fix
Comment 5 Dani Megert CLA 2011-08-22 07:23:09 EDT 
Mike, can you take care of this? I don't have PDE from Git yet.
Comment 6 Michael Rennie CLA 2011-08-22 16:49:15 EDT 
Applied patch to HEAD
Comment 7 Dani Megert CLA 2011-08-24 02:17:22 EDT 
Verified in I20110823-0925.