This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 354562 - decorate blocked reviews
Summary: decorate blocked reviews
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 18:23 EDT by Benjamin Muskalla CLA
Modified: 2014-12-19 19:01 EST (History)
1 user (show)

See Also:

Attachments
ideas (8.22 KB, image/png)
2011-08-12 07:51 EDT, Benjamin Muskalla CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2011-08-11 18:23:24 EDT 
Any review that is blocked by a negative value in any category should be decorated as being blocked. This would help to get a quick overview which commits need to be adressed again.
Comment 1 Steffen Pingel CLA 2011-08-12 06:05:43 EDT 
That's an interesting suggestion. How would you propose to decorate the review?
Comment 2 Benjamin Muskalla CLA 2011-08-12 07:51:48 EDT 
Created attachment 201387 [details]
ideas

Not quite happy with the red classes, and adding a small -1 on the task doesn't look that good. In my eyes, the "real" decoration with a little cross looks best
Comment 3 Benjamin Muskalla CLA 2011-08-12 07:54:33 EDT 
classes = glasses
Comment 4 Steffen Pingel CLA 2011-08-12 08:47:10 EDT 
The red cross looks nice. I think we should discuss generalizing this type of decoration. Other repositories may have "blocked" states as well that require users attention and there is a slight overlap with supporting staring of tasks.
Comment 5 Shawn Minto CLA 2011-08-18 13:13:24 EDT 
I think that we should consider generalizing this as there are other repositores (i.e. Rally) that have a blocked/impeded state that would be good to represent this.
Comment 6 Sam Davis CLA 2014-12-19 19:01:37 EST 
Not sure that this makes sense since a lot of the time you want to ignore reviews with test failures. Also, now that we have the dashboard view there is less need for this I think.
Comment 7 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn