354552 – Inconsistent calculation of osgi.install.area when resolving platform:/base URLs

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354552 - Inconsistent calculation of osgi.install.area when resolving platform:/base URLs

Summary: Inconsistent calculation of osgi.install.area when resolving platform:/base URLs

Status:	RESOLVED INVALID

Alias:	None

Product:	Equinox
Classification:	Eclipse Project
Component:	p2 (show other bugs)
Version:	3.7
Hardware:	PC Mac OS X - Carbon (unsup.)

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	P2 Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-08-11 16:48 EDT by DJ Houghton
Modified:	2011-08-31 17:17 EDT (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description DJ Houghton

2011-08-11 16:48:58 EDT

In the p2 code there are 2 spots where we do some processing on the platform.xml file and we resolve the platform:/base URL. Each of these location calculates the osgi.install.area location and does it different ways.

PlatformConfigurationWrapper calculates it based on the location of the launcher JARs.
The reconciler (Activator class of the bundle) checks the OSGi Location object with the install filter.

We need to determine why these are different and should they be the same? Can we always just check the Location object?

Comment 1 DJ Houghton

2011-08-16 15:07:23 EDT

This code is correct as-is. 

The touchpoint may not be installing into the current Eclipse so we get the location based on the bundle locations in the manipulator which is handed to us.

The reconciler always installs into the current Eclipse so it is ok to just use the location service.

Closing.

Comment 2 DJ Houghton

2011-08-31 17:17:13 EDT

See also discussion in bug 354888.
Although we don't want to use the install location service in the platform configuration wrapper class in the Eclipse touchpoint, we do want to calculate the value a bit differently.