Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354549 - [patch] Optional runtime dependencies in pde.runtime should be non-greedy
Summary: [patch] Optional runtime dependencies in pde.runtime should be non-greedy
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 351830
Blocks:
  Show dependency tree
 
Reported: 2011-08-11 16:28 EDT by Curtis Windatt CLA
Modified: 2011-08-25 17:20 EDT (History)
4 users (show)

See Also:
ankur_sharma: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-08-11 16:28:08 EDT 
+++ This bug was initially created as a clone of Bug #351830 +++

Cloned to backport to 3.7 SR1

CQ:WIND00261271
Build ID: Eclipse 3.7 Indigo

My product on top of Eclipse 3.7 (Indigo) includes org.eclipse.pde.runtime in order to get the PDE plug-in spy, but we do not want to include the optional JDT.

Due to the way pde.runtime marks up its optional runtime dependencies in MANIFEST.MF (along with incorrect behavior of the p2 publisher as per
bug 247099), as soon as _any_ bundle is installed from the Indigo Repository into my product, the JDT is installed silently as a side-effect.

This is not acceptable for our product since the unexpected JDT functionality leads to end user confusion.
Comment 1 Curtis Windatt CLA 2011-08-11 16:48:08 EDT 
Fix released to 3.7.1
Comment 2 Martin Oberhuber CLA 2011-08-11 17:01:26 EDT 
Awsome - thanks!

I guess this was too late for 3.7.1 RC1 but I will validate early september.
Comment 3 Curtis Windatt CLA 2011-08-17 09:42:43 EDT 
As per http://www.eclipse.org/eclipse/development/plans/freeze_plan_3_7_1.php
this bug needs a review+ on the patch from another committer and a review+ from
a component lead to be committed into 3.7.1.

Dani and Ankur, please review.
Comment 4 Ankur Sharma CLA 2011-08-17 14:27:08 EDT 
+1
Comment 5 Curtis Windatt CLA 2011-08-18 17:16:37 EDT 
Fix is released for 3.7.1.  Ankur's review satisfies the SR1 freeze requirements.
Comment 6 Curtis Windatt CLA 2011-08-25 17:20:58 EDT 
p2.inf is in M20110825-0847