Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354537 - org.apache.sshd.core missing metadata in build
Summary: org.apache.sshd.core missing metadata in build
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Lazar Kirchev CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 14:40 EDT by DJ Houghton CLA
Modified: 2011-08-12 09:15 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2011-08-11 14:40:14 EDT
When you add the URL of the latest Orbit build and view it, it seems to be missing the org.apache.sshd.core bundle. 

Turns out that it is there, but it is missing its translated information. Upon closer inspection of the metadata, it is missing 3 properties. Specifically it has:

        <property name='org.eclipse.equinox.p2.name' value='%pluginName'/>
        <property name='org.eclipse.equinox.p2.provider' value='%providerName'/>

But is missing:

        <property name='df_LT.bundleProvider' value='...'/>
        <property name='df_LT.bundleName' value='...'/>
        <property name='org.eclipse.equinox.p2.bundle.localization' value='plugin'/>

I'm not sure if this is a problem with the bundle itself or with the way its being built. I would say the first step is for the bundle owner to investigate to make sure it is set up correctly.
Comment 1 Thomas Watson CLA 2011-08-11 15:49:21 EDT
This is happening because the bundle is missing the following header:

Bundle-Localization: plugin

If the header is not specified it defaults to "OSGI-INF/l10n/bundle".  This bundle does not contain OSGI-INF/l10n/bundle.properties files so the generator cannot find the values for localization.
Comment 2 Thomas Watson CLA 2011-08-11 16:07:45 EDT
Something really strange is happening here.  The built jar is somehow missing the manifest header but the manifest in CVS looks correct.  I have no idea what is going wrong here.  David, would you know what is removing this header?
Comment 3 Lazar Kirchev CLA 2011-08-12 01:08:07 EDT
(In reply to comment #2)
> Something really strange is happening here.  The built jar is somehow missing
> the manifest header but the manifest in CVS looks correct.  I have no idea what
> is going wrong here.  David, would you know what is removing this header?

Well, I think I know what happened. Yesterday I fixed the manifests of several source bundles, and I also fixed the missing header from the sshd core bundle. That is why in the CVS it looks correct. The built jar also is OK now, the one you are looking at is probably older version, before the fix.
Comment 4 Lazar Kirchev CLA 2011-08-12 02:53:36 EDT
Fixed and released.
Comment 5 DJ Houghton CLA 2011-08-12 08:12:04 EDT
When you fixed them, did you tag with a new qualifier or just move the CVS tag?
Comment 6 Lazar Kirchev CLA 2011-08-12 09:07:35 EDT
(In reply to comment #5)
> When you fixed them, did you tag with a new qualifier or just move the CVS tag?

I tagged them with a new qualifier.
Comment 7 DJ Houghton CLA 2011-08-12 09:12:17 EDT
Ah right, sorry. I thought that I was looking at the latest version of the JAR but I wasn't.
Comment 8 Lazar Kirchev CLA 2011-08-12 09:15:23 EDT
(In reply to comment #7)
> Ah right, sorry. I thought that I was looking at the latest version of the JAR
> but I wasn't.

Never mind, it's OK. 
I tried it through the p2 install UI before closing the bug, just to be sure, and it seemed OK there.