Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354503 - HtmlDocumentBuilder should not have hard coded style for Note, Panel, etc‏
Summary: HtmlDocumentBuilder should not have hard coded style for Note, Panel, etc‏
Status: RESOLVED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 1.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 10:18 EDT by patrick.boisclair CLA
Modified: 2011-08-11 18:29 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (7.96 KB, application/octet-stream)
2011-08-11 18:29 EDT, David Green CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description patrick.boisclair CLA 2011-08-11 10:18:51 EDT 
Build Identifier: 1.5

The BlockType ElementInfofor Note, Panel,Info Warning and Tip have hard coded style that are impossible to overwrite in a normal CSS style file.


Reproducible: Always

Steps to Reproduce:
1. Create a wiki page
2. Add a {tip:tiltle=Tip title here}This is a tip comment{tip}
3. Render in html
4. Inspect the html and notice the embedded style

<div class="tip" style="border: 1px solid #090;background-color: #dfd;margin: 20px;padding: 0px 6px 0px 6px;"><p><b>Tip title here</b></p><p>This is a tip comment</p></div>
Comment 1 patrick.boisclair CLA 2011-08-11 10:22:59 EDT 
Care should be taken in finding a solution that probably does not change the current/default behavior. I am sure people are relying on the hard coded style to be there. However, this is just my opinion.
Comment 2 David Green CLA 2011-08-11 18:29:08 EDT 
Thanks for the bug Patrick.  @HtmlDocumentBuilder.setSuppressBuiltInStyles(true)@ will prevent these CSS styles from being emitted.  This setting is also available from the wikitext-to-html Ant task.  Closing as WORKSFORME.  If the setting is not sufficient for you, feel free to state your use case and propose a solution.
Comment 3 David Green CLA 2011-08-11 18:29:09 EDT 
Created attachment 201364 [details]
mylyn/context/zip