Bug 354491 – Workspace failed to start due to Problems View getting activated outside SWT Display Thread

Bug 354491 - Workspace failed to start due to Problems View getting activated outside SWT Display Thread


Summary:	Workspace failed to start due to Problems View getting activated outside SWT ...

Status:	VERIFIED FIXED

Product:	Platform
Classification:	Eclipse
Component:	UI
Version:	3.7
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.1.1
Assigned To:	Remy Suen
QA Contact:	Remy Suen

URL:
Whiteboard:
Keywords:

Depends on:	351212
Blocks:
	Show dependency tree

Reported:	2011-08-11 09:19 EDT by Remy Suen
Modified:	2011-08-19 09:16 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Remy Suen

2011-08-11 09:19:18 EDT

This clone is for tracking the fix for 4.x.

+++ This bug was initially created as a clone of Bug #351212 +++

Build ID: Eclipse 3.7 (Indigo)

1-time occurrence, see attached workspace log, here is my understanding of 
what happened:
- This was an existing fairly complex Indigo install with several dropins
- I added another *.link file to dropins (adding egit) and launched
- During launch, following exception was logged (p2 race condition?)
  org.osgi.framework.BundleException: State change in progress for bundle 
- Eclipse tried to bring up the Problems View
- But that failed due to org.eclipse.swt.SWTException: Invalid thread access
- Which caused the whole Eclipse Launch to terminate.

On relaunching, everything was fine so the config itself looked OK.

I'm reporting this since I've seen similar problems with the framework trying to activate the Problems View prematurely on other occasions too.

Comment 1 Remy Suen

2011-08-17 13:54:14 EDT

Fix cherry-picked over to R4_development.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=73671b13e7fae001d73f6bcda9fadd1b71d8b0f2

Comment 2 Remy Suen

2011-08-17 13:54:21 EDT

Whoops.

Comment 3 Dani Megert

2011-08-18 02:44:44 EDT

(In reply to comment #2)
> Whoops.

What does that mean now? ;-)

Comment 4 Remy Suen

2011-08-18 06:05:04 EDT

(In reply to comment #3)
> (In reply to comment #2)
> > Whoops.
> 
> What does that mean now? ;-)

It means I forgot to set the status to RESOLVED/FIXED when I entered comment 1.

Comment 5 Dani Megert

2011-08-19 09:15:10 EDT

Verified in 4.1.1-M20110817-2001.

NOTE THOUGH: currently 4.1.1 consumes ui.ide from 3.7.1 i.e. it is not verified that the code in R4_development is not verified and not currently in a build.

Comment 6 Dani Megert

2011-08-19 09:16:49 EDT

> it is not verified that the code in R4_development is not verified 
is *good*