Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354476 - Feedback to first contribution: lucene.core
Summary: Feedback to first contribution: lucene.core
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Robert Wetzold CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 07:11 EDT by Robert Wetzold CLA
Modified: 2012-01-20 14:34 EST (History)
1 user (show)

See Also:

Attachments
lucene.core 3.0.3 (1.93 MB, application/zip)
2011-08-11 07:11 EDT, Robert Wetzold CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Wetzold CLA 2011-08-11 07:11:08 EDT 
Created attachment 201308 [details]
lucene.core 3.0.3

Hi,

as discussed on the mailing list I will make several contributions to Orbit. It would be great if, before we actually submit, someone else could double check that we have got the structure right. The new v3_0_3 branch is already created.

If this bundle is ok we will proceed accordingly with all the others and link them to the main feature. 


Regards, Robert
Comment 1 David Williams CLA 2011-08-15 13:33:46 EDT 
I took a quick look, and basically looks ok, though is hard to tell from a quick peek at zip file. The "hard part" is getting it into the right branch, etc., in CVS ... so I recommend you go ahead and try that ... get it into cvs. 

Then, if you haven't yet, use Eclipse to "compare" with the 291 version to see if everything looks similar ... that is, manifest.mf and similar. 

(And, you know you can even check out both version into workspace, right? Use the "check out as ..." action, which give you a chance to get your workspace project its own unique name, such as org.apache.lucene.core v291 or similar.)

HTH
Comment 2 David Williams CLA 2012-01-20 14:34:57 EST 
I see this in a build now, so assume we can mark as fixed? Feel free to reopen if I've misunderstood. Also, its nice to set the target milestone for when it first appeared ... not sure if Juno M5, or Juno M2? ...