Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354456 - Wrong manifest for org.apache.mina.core.source
Summary: Wrong manifest for org.apache.mina.core.source
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Gunnar Wagenknecht CLA
QA Contact: Lazar Kirchev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 02:24 EDT by Gunnar Wagenknecht CLA
Modified: 2011-08-11 10:39 EDT (History)
0 users

See Also:

Attachments
patch with corrected source bundle manifest (12.85 KB, patch)
2011-08-11 02:24 EDT, Gunnar Wagenknecht CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2011-08-11 02:24:16 EDT 
Created attachment 201292 [details]
patch with corrected source bundle manifest

The manifest of org.apache.mina.core.source contains import and export packages header. This is wrong because it does not contain any class files but only Java source files. Usually, the source bundle manifest is very minimal (see the attached patch).
Comment 1 Gunnar Wagenknecht CLA 2011-08-11 02:29:21 EDT 
Fix committed and released. Lazar, please verify.
Comment 2 Lazar Kirchev CLA 2011-08-11 02:35:45 EDT 
(In reply to comment #1)
> Fix committed and released. Lazar, please verify.

It's OK. Thanks a lot, Gunnar!  

I will fix the manifests of all source bundles I have added, since
I have left the imports/exports in all of them. I will open a bug for this.

But it was not clear from the wiki page for adding source bundles how exactly
should the manifest look like. However, I should have checked some other source
bundle to see what the manifest should be.

Still, probably we should add this to the wiki?
Comment 3 Gunnar Wagenknecht CLA 2011-08-11 02:38:11 EDT 
(In reply to comment #2)
> Still, probably we should add this to the wiki?

That's a good idea. Are you volunteering? :)
Comment 4 Lazar Kirchev CLA 2011-08-11 02:40:56 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Still, probably we should add this to the wiki?
> 
> That's a good idea. Are you volunteering? :)

Yes, I will do it. I will edit the page.
Comment 5 Lazar Kirchev CLA 2011-08-11 10:36:40 EDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Still, probably we should add this to the wiki?
> > 
> > That's a good idea. Are you volunteering? :)
> 
> Yes, I will do it. I will edit the page.

I edited the page, http://wiki.eclipse.org/Orbit_Bundle_Checklist#Create_a_Source_Bundle

Would you review the change?
Comment 6 Gunnar Wagenknecht CLA 2011-08-11 10:39:09 EDT 
(In reply to comment #5)
> I edited the page,
> http://wiki.eclipse.org/Orbit_Bundle_Checklist#Create_a_Source_Bundle

Looks good. Thanks!