Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354418 - [Compatibility] Views leak models and managers of tool bars and menus
Summary: [Compatibility] Views leak models and managers of tool bars and menus
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.2 M2   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 14:17 EDT by Remy Suen CLA
Modified: 2011-09-13 08:33 EDT (History)
3 users (show)

See Also:

Attachments
CompatibilityView patch v1 (1.83 KB, patch)
2011-08-15 09:36 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-08-10 14:17:28 EDT 
In CompatibilityView's createPartControl(*), we link the model and manager with their renderers but this is never cleared. This translates to four leaked objects per disposal, the model and manager of both the tool bar and the part's menu.
Comment 1 Remy Suen CLA 2011-08-15 09:36:59 EDT 
Created attachment 201493 [details]
CompatibilityView patch v1

Patch to remove the linking between the renderer and the model when the part is being disposed.
Comment 2 Remy Suen CLA 2011-08-15 09:37:21 EDT 
(In reply to comment #1)
> Created attachment 201493 [details]
> CompatibilityView patch v1

Eric, please review for release to 4.1.1, thanks.
Comment 4 Remy Suen CLA 2011-09-13 08:33:54 EDT 
Verified by code inspection with I20110912-0200.