Community
Participate
Working Groups
Build Identifier: 20110615-0604 [17:20:17 | Bearbeitet 17:20:27] Bernd: If an ereference feature contains a detached object (e.g. if a contained object was removed from its containment relationship), then the call of containsAll() will return false instead of true. I attached a junit test which demonstrates this problem. I also see this problem with contains(), but I was not able to reproduce this in an unit-test. I think the problem could be in org.eclipse.emf.internal.cdo.view.CDOStoreImpl.contains() where the CDOID of the object will be used for check the containment in the CDORevision values, but in the case of a detached object, the objected itself will be hold in the CDORevision not only its id. Reproducible: Always Steps to Reproduce: 1. see unit-test 2. 3.
Created attachment 201251 [details] JUnit-Test
Thanks for the good test case. I'll fix this in 4.1 first and backport to maintenance later.
Created attachment 201256 [details] Fix
Stefan, for the contributed test case, please confirm that: 1) The number of lines that you changed is smaller than 250. 2) You are the only author of these changed lines. 3) You apply the EPL to these changed lines.
Committed revision 8893
Backport to 4.0 in bug 354412.
Hi, I confirm that The number of lines that I changed is smaller than 250. I'm the only author of these changed lines. I apply the EPL to these changed lines. and thank you for the fast fix.
Created attachment 201258 [details] Add-on fix (incremental) Fixes 3 test failures in legacy mode.
Closing.
