Community
Participate
Working Groups
The valgrind version number is seted when the ValgrindOptionTab is initialed and can not be changed anymore. In some user case, maybe we need to change the version number on fly. Can we add a setter/getter for the variable valgrindVersion?
If we can provide a setter/getter for the variable "valgrindVersion", after the version is changed . the control should also redraw.
Background: In our product, we run valgrind on remote targets (by extending the original Linuxtools launches). Since a different valgrind version can be installed on different targets, and users can select a different target in the UI, it's important to be able and change the valgrind version.
Created attachment 201221 [details] patch v1 Attached is a simple patch against master. I don't think we can redraw controls while a tab is being displayed... I've never seen an SWT control vanish or reappear based on a change on that page (well, except a "Details>>" button in dialogs. So my first approach is only allowing to change the valgrind version while the tab is not being displayed. That's good enough for our approach, where a different tab will pick the connection. Switching back to the valgrind tab, the tab should be redrawn. Ryan, could you check whether that patch fits your needs?
Ping, could my patch be reviewed / considered ? FWIW, in our commercial product we use introspection today, in order to access the private "valgrindVersion" field.
(In reply to comment #4) > Ping, could my patch be reviewed / considered ? > > FWIW, in our commercial product we use introspection today, in order to access > the private "valgrindVersion" field. Patch is very reasonable considering that remote Valgrind version will have to be calculated once user has picked target. Patch has been applied to master.
Comment on attachment 201221 [details] patch v1 Less than 250 lines.
