Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354329 - GraphicalNodeEditPolicy.getConnectionCreateCommand() javadoc is incorrect
Summary: GraphicalNodeEditPolicy.getConnectionCreateCommand() javadoc is incorrect
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 3.7.1 (Indigo SR1)   Edit
Assignee: Alexander Nyßen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 02:37 EDT by Arieh Bibliowicz CLA
Modified: 2011-08-23 16:40 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arieh Bibliowicz CLA 2011-08-10 02:37:18 EDT 
Build Identifier: 20110615-0604

Javadoc states that "This Command will be passed to the target node EditPart." but this is not automatic and must be implemented using request.setStartCommand(). Confuses the used of the framework.

Reproducible: Always

Steps to Reproduce:
1. Implement GraphicalNodeEditPolicy.getConnectionCreateCommand() and GraphicalNodeEditPolicy.getConnectionCompleteCommand(). In first function create a simple command and in the second function test if the command can be fetched.
2. Connect two nodes in the diagram
Comment 1 Alexander Nyßen CLA 2011-08-23 16:40:27 EDT 
Changed javadoc to clarify that setting the start command lies within the responsibility of the implementor. Changed in 3.7 maintenance branch (3.7.1) and in HEAD (3.8).