Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354326 - [windows] Person_me icon in attachments should have transparent background
Summary: [windows] Person_me icon in attachments should have transparent background
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P4 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2011-08-10 02:02 EDT by Sam Davis CLA
Modified: 2011-08-11 06:50 EDT (History)
1 user (show)

See Also:

Attachments
white background (1.85 KB, image/png)
2011-08-10 02:03 EDT, Sam Davis CLA 		no flags Details
mylyn/context/zip (982 bytes, application/octet-stream)
2011-08-10 13:59 EDT, Steffen Pingel CLA 		no flags Details
mylyn/context/zip (45.63 KB, application/octet-stream)
2011-08-10 14:52 EDT, Sam Davis CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2011-08-10 02:02:24 EDT 
The person_me icon in the attachments table should have a transparent background.
Comment 1 Sam Davis CLA 2011-08-10 02:03:42 EDT 
Created attachment 201205 [details]
white background

This is how it looks now when there's a blue incoming highlight. It should be transparent so you don't see the white block.
Comment 2 Steffen Pingel CLA 2011-08-10 06:11:30 EDT 
The background is rendered transparently on Gtk at least. Are you on Windows XP?
Comment 3 Shawn Minto CLA 2011-08-10 11:05:56 EDT 
Turns out that I see this as well on win 7.  Maybe this is a problem with adding an image to a cell?
Comment 4 Steffen Pingel CLA 2011-08-10 11:39:41 EDT 
Can you try converting the image to a PNG? Do you see this in other lists as well, e.g. on the Annotations preferences page?
Comment 5 Sam Davis CLA 2011-08-10 11:59:16 EDT 
I don't, but that page has a white background anyway, so I wouldn't be able to tell. Note that it's not a problem when you select the item, but only when there is an incoming highlight, so I think it's actually not the image backgroudn that is the problem, but rather that setting the highlight doesn't set the background color on the Label (or whatever contains the image).
Comment 6 Sam Davis CLA 2011-08-10 12:00:50 EDT 
(I think bug 344770 was the same kind of problem.)
Comment 7 Steffen Pingel CLA 2011-08-10 13:59:14 EDT 
Thanks for clarifying. I misinterpreted the highlighting as a selection.
Comment 8 Steffen Pingel CLA 2011-08-10 13:59:16 EDT 
Created attachment 201261 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2011-08-10 14:03:54 EDT 
I still can't reproduce this on Gtk. Can you check if it makes a difference to reorder statements in org.eclipse.mylyn.internal.tasks.ui.editors.AttachmentTableLabelProvider.update(ViewerCell)?
Comment 10 Sam Davis CLA 2011-08-10 14:52:11 EDT 
I can't find a way to fix this. I can confirm that the image has a transparent color, but it seems it may be an SWT bug (see my context). I even tried messing around with PaintListeners but could not make it work; that may be the way to fix it though.
Comment 11 Sam Davis CLA 2011-08-10 14:52:15 EDT 
Created attachment 201268 [details]
mylyn/context/zip
Comment 12 Sam Davis CLA 2011-08-10 14:52:45 EDT 
Also, all the images that get displayed in that table have the same problem.
Comment 13 Steffen Pingel CLA 2011-08-11 06:50:31 EDT 
If you have a small snippet it could be worth filing a bug against SWT.
Comment 14 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn