Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354241 - [relengtool] 'Fix Copyrights' action doesn't appear on projects using subclipse anymore
Summary: [relengtool] 'Fix Copyrights' action doesn't appear on projects using subclip...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.7.1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-09 08:52 EDT by Nicolas Bros CLA
Modified: 2011-08-18 09:31 EDT (History)
4 users (show)

See Also:
dimitar.georgiev: review+

Attachments
Fix for 3.7.1 (2.28 KB, patch)
2011-08-18 08:39 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-08-09 08:52:31 EDT 
Since Indigo, the "Fix Copyrights" action doesn't appear on projects that use the Subclipse SVN connector. It used to work with the Helios version of the releng tool.
Comment 1 Dimitar Georgiev CLA 2011-08-09 10:21:21 EDT 
I am also experiencing this using indigo + egit. The action just does not show, and there are no entries in the error log.

Eclipse SDK
Version: 3.7.0
Build id: I20110613-1736

Eclipse EGit
1.0.0.201106090707-r

Eclipse Releng Tools
3.4.100.v20110503-45-7w31221634
Comment 2 Dimitar Georgiev CLA 2011-08-15 12:31:48 EDT 
I have raised the importance to major since this affects all Eclipse projects using GIT version control and eclipse 3.7. The "Fix copyrights" action will only work on CVS-located resources.

This is because the object contribution for the action has a wrong filter:

<filter
               name="projectPersistentProperty"
               value="org.eclipse.team.core.repository=org.eclipse.team.cvs.core.cvsnature">
         </filter>

Dani, it looks like this is a regression introduced in

Fixed bug 343954: [relengtool] Fix Copyrights action should be available on working sets

i.e. version 1.18 of the releng.tools plugin.xml.

Can you please take a look?

Regards, Dimitar
Comment 3 Dimitar Georgiev CLA 2011-08-18 06:29:34 EDT 
Nicholas, the problem has a workaround. If you place all your projects in a Java working set, and make the package explorer show working sets as top level elements, you will be able to fix copyrights through right-clicking the workin set node.
Comment 4 Dani Megert CLA 2011-08-18 08:39:28 EDT 
Created attachment 201713 [details]
Fix for 3.7.1
Comment 5 Dani Megert CLA 2011-08-18 08:43:10 EDT 
Fixed in HEAD.
Available in builds >= N20110818-2000.

Let me know if this fixes the issue for you. I'll then put it to 3.7.1.
Comment 6 Dimitar Georgiev CLA 2011-08-18 09:07:49 EDT 
Tested, looks good. It fixes the issue. Thanks!
Comment 7 Dani Megert CLA 2011-08-18 09:31:30 EDT 
+1 for 3.7.1.

Fixed in R3_7_maintenance.
Available in builds >= M20110824-0800.