Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354223 - Helgrind doesn't export its package
Summary: Helgrind doesn't export its package
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Valgrind (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.8.1   Edit
Assignee: Daniel Henrique Barboza CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 344504
Blocks:
  Show dependency tree
 
Reported: 2011-08-09 05:11 EDT by Martin Oberhuber CLA
Modified: 2011-09-07 08:50 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2011-08-09 05:11:03 EDT 
Build ID: 0.8.0 (Indigo)

As of the Indigo 0.8.0 release, the o.e.linuxtools.valgrind.helgrind MANIFEST.MF does not export its Java package.

In master, the respective export has been added. Could that please be backported to 0.8.1 since we need it for a customization for our product.

The other valgrind tools also export their packages, and in fact exporting packages is considered good practice at Eclipse:
http://wiki.eclipse.org/Export-Package
Comment 1 Andrew Overholt CLA 2011-08-15 09:24:59 EDT 
Daniel, can you please supply a patch for this?  Thanks.
Comment 2 Martin Oberhuber CLA 2011-09-07 06:56:38 EDT 
It looks like this has been fixed in the stable-0.8 branch on 15-Aug:

http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/commit/valgrind/org.eclipse.linuxtools.valgrind.helgrind/META-INF/MANIFEST.MF?h=stable-0.8&id=352d3ced8833364133f52fc9cdb9352a9a2ce565

So this bug can be closed ... (marking target 0.8.1 for now).
Comment 3 Andrew Overholt CLA 2011-09-07 08:50:06 EDT 
Heh, I forgot I fixed this to get the tests to work :)