Community
Participate
Working Groups
Line 308 references the memento variable, but this variable could be null since it is outside the check for null at line 283. Also, line 290 creates a memento that is never used. If this is not an error, then the redundant code should be removed.
(In reply to comment #0) > Line 308 references the memento variable, but this variable could be null since > it is outside the check for null at line 283. We can move the code from line 306 to line 311 into the if-statement that checks for null. > > Also, line 290 creates a memento that is never used. If this is not an error, > then the redundant code should be removed. I was not quite sure if the method call putString(LAYOUT, layout) would be enough, or if I should create a new child. To be sure I toke the second one. Should I change to the first option?
(In reply to comment #1) > > Also, line 290 creates a memento that is never used. If this is not an error, > > then the redundant code should be removed. > > I was not quite sure if the method call putString(LAYOUT, layout) would be > enough, or if I should create a new child. To be sure I toke the second one. > Should I change to the first option? I'd suggest creating the new child, then adding the layout to it.
Fixed in ptp_5_0 and HEAD.
