Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354139 - JS: MVC
Summary: JS: MVC
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Justin Spadea CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 358380 359504 (view as bug list)
Depends on: 354560
Blocks:
  Show dependency tree
 
Reported: 2011-08-08 10:35 EDT by Scott Greer CLA
Modified: 2017-02-23 14:15 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Greer CLA 2011-08-08 10:35:50 EDT
The plan is to spend this iteration figuring out what, if anything, we should do for MVC in EDT 0.7.0 and next iteration implementing whatever we decide on.
Comment 1 Scott Greer CLA 2011-09-21 09:46:03 EDT
*** Bug 358380 has been marked as a duplicate of this bug. ***
Comment 2 Scott Greer CLA 2011-10-06 11:51:21 EDT
I am committing the JS gen portion of this enhancement;  it has been partially tested but there are remaining issues elsewhere:
* IRs will require work to support WrapperedFields
* Date/time formatting in EDT is different from RBD and seems to be incompletely designed
* The ValidValues annotation also requires MOF/Compiler work before JS gen can support it.
* The DnD Wizard doesn't appear to generate the correct EGL source, so testing MVC with DnD cannot begin.


After talking with Brian, it seemed best to commit what I have and move on to other bugs;  I've confirmed that the MVC gen logic will have not break JS gen if MVC gen isn't used.
Comment 3 Scott Greer CLA 2011-10-06 11:56:53 EDT
As a follow-up to comment #2, I am NOT committing the formatter/validator annotations for MVC at this time for two reasons:  first, because we're not ready for testing to begin, and second, we haven't decided whether these annotations belong in the widget project or in a MOFAR.
Comment 4 Scott Greer CLA 2011-10-06 11:58:25 EDT
*** Bug 359504 has been marked as a duplicate of this bug. ***
Comment 5 Brian Svihovec CLA 2011-10-16 14:52:19 EDT
Scott,

There are two components to the MVC Framework:

1) Assigning Data to and from the model, which includes; the MVC annotation, with its Model and View fields, and the Controllers, with all of its delegates.

2) The Validation and Formatting annotations that can appear on the data that is bound to the View

Looking at comment 2 below, it seems that most of the remaining work is for item #2 above.  Can you describe the work that is left for item #1?  NOTE: I realize that there is implicit validation and formatting that occurs when moving data for specific types, without using the Validation and Formatting annotations, but we can exclude this for now and just focus on the movement of data and the controller delegates.
Comment 6 Scott Greer CLA 2011-10-17 16:17:48 EDT
In response to comment #5:
1) Yes, this is what I think of as "core" MVC and it is complete.
2) For the reasons given in comment #2, some of the formatter/validator annotations could not be tested.  From my unit-testing notes, the following annotations worked -- F indicates formatter, V indicates validator:

* currency (F)
* currencySymbol (F)
* inputRequired (V)
* isDecimalDigit (V)
* isHexDigit (V)
* lowercase (F)
* minimumInput (V)
* numericSeparator (F)
* sign (F)
* uppercase (F)

Others on this list may or may not work (again, subject to the caveats in comment #2);  some of them I didn't test because I didn't know enough about how they work / what to expect.
Comment 7 Justin Spadea CLA 2011-11-01 10:14:16 EDT
MVC work is complete. Fixes have been made in generation, widgets, and js runtime.
Comment 8 Lisa Lasher CLA 2011-11-09 14:02:48 EST
Closing this work item