Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 354136 - Allow compilers to specify the default imports for system parts
Summary: Allow compilers to specify the default imports for system parts
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Tony Chen CLA
QA Contact:
URL:
Whiteboard: Extensibility_Compile
Keywords:
Depends on:
Blocks: 362628
  Show dependency tree
 
Reported: 2011-08-08 10:20 EDT by Paul Harmon CLA
Modified: 2017-02-23 14:19 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Harmon CLA 2011-08-08 10:20:56 EDT
Add an api to compilers to allow them to specify the default imports for system parts. Update SystemEnvironment and FileScope to honor the settings from the compiler.
Comment 1 Tony Chen CLA 2011-09-30 05:01:27 EDT
Paul, can you please elaborate more background for this enhancement. Here's my understanding and some thoughts

Back in RBD, we have eglIsSystemPart annotation which annotate these Parts we think are system. It seemed this annotation is gone in EDT. One of the broken functions is Organize Import, which will now imports these "System Parts" and "System Annotations", for example, eglx.lang.basicprogram & import eglx.lang.syslib as mentioned in Bug 354445

Do a reference search for PartBinding.isSystemPart(), I can find 11 references. We probably should revisit all of them. 
AnnotationTypeBinding.isSystemAnnotation() is just used once by Organize Import. 

Let's just look at the Organize Import function, can we assume that every part and annotation can be found in SystemEnvironment is "System", and have them import by default (no need to generate import statement). If we do this, then we don't need to specify the default imports. I don't know if there's a case that a Part is in SystemEnvironment but we want it to be specifically imported.
Comment 2 Brian Svihovec CLA 2011-10-03 21:12:39 EDT
Paul, please confirm that this work can be deferred until after EDT .7.
Comment 3 Paul Harmon CLA 2011-10-05 08:14:13 EDT
This is not critical for 0.7...Lets defer this to future.
Comment 4 Matt Heitz CLA 2013-01-03 14:43:17 EST
Setting the target milestone to Future for bugs that won't be addressed in 0.8.2.